Make "Place navigation block" a primary button and move it right before the table

Created on 14 March 2024, 3 months ago
Updated 26 April 2024, 2 months ago

Problem/Motivation

At the moment the Place navigation block button is located within the first table row on admin/config/user-interface/navigation-block. Functionally it not really belongs there, since for one it is no draggable menu/navigation block plus it has less affordance through the close proximity to the table header in lighter grey. But it sort of follows the pattern employed on the Block layout page you have blocks grouped by block regions, but on the Navigation blocks page there are no groups and so the button is simply placed inside the Navigation block column without a group label in front of it.

Steps to reproduce

Go to /admin/config/user-interface/navigation-block

Proposed resolution

The easiest way to improve the situation would be by moving the Place navigation block button out of the table and make it a primary button. The same was done for form modes(/admin/structure/display-modes/form) and view modes (/admin/structure/display-modes/view) recently to get a dedicated primary button on top of the table. That way you have a clear separation of concerns in particular for a table without any grouping.

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request
Status

Closed: outdated

Version

1.0

Component

User interface

Created by

🇩🇪Germany rkoller Nürnberg, Germany

Live updates comments and jobs are added and updated live.
  • Usability

    Makes Drupal easier to use. Preferred over UX, D7UX, etc.

Sign in to follow issues

Comments & Activities

  • Issue created by @rkoller
  • 🇪🇸Spain ckrina Barcelona

    @rkoller first, thanks for taking the time to review this! :D

    Getting into your proposal, I don't think I agree with it. This is why:

    First, we already have the primary button for the form at the end of the form. And that's my main reason for it.

    Functionally it not really belongs there, since for one it is no draggable menu/navigation block plus it has less affordance through the close proximity to the table header in lighter grey.

    It actually is a draggable area :) Plus I think it does belong there because it's the tool that you need to add more items to that specific table/list of elements. About the "it has less affordance through the close proximity to the table header in lighter grey", I do agree but that's more a design problem with the grey regular buttons we'll hopefully solve with the new designs from 📌 [META] Implement the final design system Fixed (and hopefully we get rid of the 50 shades of gray :D).

    Anyway, happy to keep discussing this if you don't agree :)

  • 🇩🇪Germany rkoller Nürnberg, Germany

    thank you for explaining your points! and yes I disagree in this case, but i will try illustrate my arguments with a few screenshots (something i should have already done in my initial issue summary).

    First in regards of the primary button. There are several examples across the admin ui that have two primary buttons, one to save the configuration form and one for adding something. Two examples are:


    Both have a primary add button adding an object to the draggable area underneath. The suggestion making the button a primary button was mainly due to consistency reasons since more or less all add buttons across the admin ui are blue primary buttons.

    And in regards of the draggable area i meant the following. The block layout page is sort of a special case from my perspective. one of the very few cases where it makes "sort of" sense to have some kind of "section headers" within the block list containing each the label for the block region and the place block button, which provides the convenience that the block is directly placed into the block region the button is pressed. but these highlighted block region rows are in contrast to the other rows not draggable (they even miss a drag handle):

    Same for the row on the navigation blocks page, that row with just the place navigation block button is also not draggable but in contrast to the block layout page it doesn't contain any sections. That is the reason why i've thought it would make sense to move the place navigation block button out of that table. it just feels out of place there.

    One compromise might be to move the button out of the table but instead of making it a blue primary button keep it as a grey regular button? but as i said the suggestion making it a blue primary button was based on consistency reasons.

  • Status changed to Closed: outdated 2 months ago
  • 🇩🇪Germany rkoller Nürnberg, Germany

    saw in todays ux meeting that the navigation blocks page changed to a layout builder based approach. so i close this as outdated.

Production build 0.69.0 2024