- Issue created by @Nathan Tsai
- π¨π¦Canada Nathan Tsai
Note: I set this category to "Bug Report" because I assume that it should be impossible to configure Gutenberg to lead to a 500 error.
- π΅πΉPortugal marcofernandes
Actually kind of waiting for this π± Make pre-save entity validation more commonplace (e.g., the default) Active
But I guess we can do some validation when "pushing" the block value into the node entity (on the existing entity_presave hook).
I don't think it would be necessary to have a "required" property to the template since we can get that from the field that is mapped.
It would be nice to have some kind of visual indication that the block is required and I think we can do that by getting the info from the field. - First commit to issue fork.
- Status changed to Needs review
7 months ago 12:31pm 25 May 2024 - πΊπΈUnited States loze Los Angeles
This also does not add any sort of required indicator. I needed something quick that prevented people from trying to save nodes with no titles.
- π΅πΉPortugal marcofernandes
Not easy to fit a visual indicator for the required mapping fields. And I mean that in a styling perspective. I tried the usual (*), a red outline border and even a different background color for the block but I didn't like the results.
I made some changes so the mapping fields filter is ready to handle the required fields but, for now, I just added at the sidebar a text telling that the field is required π€·ββοΈ
We'll revisit this with some designers/UX experts opinions π
For now, I'm happy with the MR. Good work and thank you @loze.
-
marcofernandes β
committed ea236c7f on 3.x authored by
loze β
Issue #3427432 - validate required mapped fields
-
marcofernandes β
committed ea236c7f on 3.x authored by
loze β
- Status changed to Fixed
7 months ago 8:30am 28 May 2024 -
marcofernandes β
committed ea236c7f on 3.0.x authored by
loze β
Issue #3427432 - validate required mapped fields
-
marcofernandes β
committed ea236c7f on 3.0.x authored by
loze β
Automatically closed - issue fixed for 2 weeks with no activity.