- Issue created by @sunlix
- πΊπΈUnited States AaronBauman Philadelphia
Breaks https://www.drupal.org/project/contact_block β as well, when you add a Contact Block to a node via the paragraph.
Cross-linking π Gin + Paragraph Layouts conflict Active
- Status changed to Needs review
about 2 months ago 6:39pm 30 April 2024 - πΊπΈUnited States AaronBauman Philadelphia
Here's a patch that adds an additional alter hook so that nested forms can be excluded by id.
Solved the conflict with contact block for me using the following implementation:
function my_module_gin_form_ids_to_ignore_alter(array &$ids) { $ids[] = 'contact'; }
- Merge request !415Issue #3427327: Layout paragraphs breaks .gin-actions - Add an additional hook... β (Open) created by AaronBauman
- πΊπΈUnited States AaronBauman Philadelphia
MR 415 opened with same patch from #4
- Status changed to Postponed: needs info
21 days ago 6:06pm 6 June 2024 - π¨πSwitzerland saschaeggi Zurich
Please test this if β¨ Move Action buttons to sticky header Needs review will fix this issue, thanks!
- Status changed to Needs review
20 days ago 3:46pm 7 June 2024 - πΊπΈUnited States AaronBauman Philadelphia
The primary conflict is the logic Gin uses in
GinContentFormHelper::isContentForm
and the paragraphs layout implementation.When the paragraphs layout renders a subform inside a node form, Gin flags the subform as a content form, breaking the actions on the node form.
Since #3356717 does not change that logic, the problem persists regardless.
- Status changed to Postponed: needs info
18 days ago 7:35pm 9 June 2024 - π¨πSwitzerland saschaeggi Zurich
@AaronBauman I tested this with the steps given in the description and the patch from my mentioned MR with the refactored sticky action logic (https://git.drupalcode.org/project/gin/-/merge_requests/420.diff) and I can't reproduce this. Make sure to clear the cache when you apply the patch π
- Status changed to Closed: duplicate
17 days ago 1:41pm 10 June 2024 - πΊπΈUnited States AaronBauman Philadelphia
OK, you're right, seems to have been resolved by #3356717
- π©πͺGermany sunlix Wesel
Hey, I also can confirm that the new sticky actions implementation solved this behavior described here. :-)
Thank you for your work! :) I like the new sticky actions.