Contrib.social

Top Bar entity actions do not include "Layout" page

Open on Drupal.org →
Created on 12 March 2024, 4 months ago
Updated 29 March 2024, 3 months ago

Problem/Motivation

Top Bar shows Entity actions as a dropdown instead of local tasks.

In order to discover the routes where this should happen, Navigation checks the entity type routes defined as links.

However, Layout Builder follows a different approach for that.

So, NavigationRenderer service is not able to recognize Layout Builder overrides page as an entity operation route and shows the tabs instead of the top bar operations.

Steps to reproduce

  1. Install Umami
  2. Go to Navigation Settings (/admin/config/user-interface/navigation/settings)
  3. Disable the Hide Top Bar option
  4. Visit a node page like /recipes/crema-catalana and confirm that tabs are not present and the top bar shows the different related pages
  5. Check other options like edit or delete and confirm that top bar behavior is the expected one
  6. Select the "Layout" Top Bar dropdown option and confirm that this page shows tabs instead of the Top Bar dropdown

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇪🇸Spain plopesc Valladolid

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @plopesc
  • Merge request !192Issue #3427301: Top Bar entity actions do not include "Layout" page → (Merged) created by plopesc
  • Pipeline finished with Success
    4 months ago
    Total: 171s
    #117202
  • Status changed to Needs review 4 months ago
  • Comment 4 months ago →
    🇪🇸Spain plopesc Valladolid

    MR created

  • Comment 4 months ago →
    🇮🇳India Kanchan Bhogade

    Hi
    I've tested MR !192 on Drupal 11.x

    Tsetng steps:

    1. Install Umami
    2. Install Navigation Module
    3. Go to Navigation Settings (/admin/config/user-interface/navigation/settings)
    4. Disable the Hide Top Bar option
    5. Visit a node page like /recipes/crema-catalana and confirm that tabs are not present and the top bar shows the different related pages
    6. Check other options like edit or delete and confirm that top bar behavior is the expected one
    7. Select the "Layout" Top Bar dropdown option and confirm that this page shows tabs instead of the Top Bar dropdown

    Test Result:
    For the layout showing the Dropdown at the top bar

    Adding screenshots for reference

    keeping in "needs Review" for code verification

  • Pipeline finished with Success
    4 months ago
    Total: 144s
    #117485
  • Status changed to Fixed 3 months ago
  • Comment 3 months ago →
    🇪🇸Spain ckrina Barcelona

    Looks good to me. Merged, thanks!

  • Pipeline finished with Success
    3 months ago
    Total: 201s
    #119953
  • Comment 3 months ago →
    System Message
  • Comment 3 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Success
    2 months ago
    Total: 55s
    #153094
  • Pipeline finished with Success
    2 months ago
    Total: 54s
    #153123
  • Pipeline finished with Success
    2 months ago
    #153131
  • Pipeline finished with Success
    18 days ago
    Total: 186s
    #194499
  • Pipeline finished with Success
    18 days ago
    Total: 175s
    #194501
contrib.social Blog FAQ Discussions
Production build 0.69.0 2024