Infinite loop with custom DefaultExceptionHtmlSubscriber and JSON:API\REST endpoint

Created on 12 March 2024, 4 months ago

Updated 19 March 2024, 3 months ago

Problem/Motivation

The site ends up in a infinite loops while using a custom class extending DefaultExceptionHtmlSubscriber and JSON:API or REST resource.

Steps to reproduce

Implement a basic subscriber extending DefaultExceptionHtmlSubscriber

final class MyEventSubscriber extends DefaultExceptionHtmlSubscriber {
  /**
   * {@inheritdoc}
   */
  protected static function getPriority() {
    return 100;
  }

  public function on403(ExceptionEvent $event) {
    $request = $event->getRequest();
    $route_name = $request->attributes->get('_route');

    if (str_starts_with($route_name, 'my_route')) {
      $redirect_url = Url::fromRoute('<front>')
        ->toString();
      $returnResponse = new RedirectResponse($redirect_url);
      $event->setResponse($returnResponse);
    }
  }

  /**
   * {@inheritdoc}
   */
  protected function getHandledFormats() {
    return [];
  }

}

GET some JSON:API or REST resource which throws a 40x exception.
402, 404, 405 will return

: Allowed memory size of 1073741824 bytes exhausted (tried to allocate 69632 bytes) in
on line

401 or 403 error still work.

💬 Support request

Status

Active

Version

10.2 ✨

Component

Routing →

Last updated 2 days ago

Maintained by
🇺🇸United States @tim.plunkett

Created by

🇮🇹Italy Giuseppe87

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @Giuseppe87
Comment 4 months ago →
🇺🇸United States cilefen
There is not enough here for a bug report. What is in some code?
Comment 4 months ago →
🇮🇹Italy Giuseppe87
Comment 4 months ago →
🇮🇹Italy Giuseppe87
I've updated the example with the actual code I used to cause this behaviour.
Comment 3 months ago →
🇮🇹Italy Giuseppe87
As workaround I've found that limiting the handled formats to 'html' wont' cause the loop.

E.g.

protected function getHandledFormats() { return ['html']; }
or just don't overriding the method of the parent class.

This obliviously works only if the subscriber doesn't need to intercept json\rest request. I haven't tested the case a json\rest request is handled inside the on403 on404 methods.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024