Broken redirect from RouteNormalizerRequestSubscriber when ajax_page_state present and $request->overrideGlobals() has been called

Added a test to show the error plus the a potential solution so setting to needs review although I note in the issue summary that there may be other ways to resolve this issue that I am keen to here ideas on.

Test is failing as method only exists from 10.1 onwards

Using MR88 as a composer patch fixes the issue on our Drupal 10.2.4 site.

            "drupal/redirect": {
                "Broken redirect from RouteNormalizerRequestSubscriber when ajax_page_state present and $request->overrideGlobals() has been called - https://www.drupal.org/project/redirect/issues/3426938#comment-15483275": "https://git.drupalcode.org/project/redirect/-/merge_requests/88.diff"
            },

@sonnykt: You must not use merge request URL's as patches. anyone can commit code to that that will then run on your site. Always tore them as local files.

I've disabled D9 testing in the meantime, so I guess this will no longer fail. A bit unsure about committing this without raising the Drupal required core version, but it's just a test. Could add a check if that function exists and then skip the test.

Tests fail on 10.1 as well, that's definitely not OK. Fine to skip the test if it's a 10.2+ problem.

@Berdir Thanks - I have updated the test - it was failing on 10.1 as AjaxPageState was introduced in 10.2 not 10.1 as I previously noted incorrectly in my comment.

I think the bug is still relevant for 10.1 if other code is modifying request parameters - I've added a check to the test to see if AjaxPageState exists and to modify the request params in the test if it doesn't - so test runs and passes on both current and previous minor.

Added couple wording suggestions, but otherwise looks good to me!

+1 RTBC

I'm seeing

richtigung TypeError: Drupal\Component\Utility\UrlHelper::uncompressQueryParameter(): Argument #1 ($compressed) must be of type string, null given, called in /web/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php on line 50 in Drupal\Component\Utility\UrlHelper::uncompressQueryParameter() (Zeile 106 in /web/core/lib/Drupal/Component/Utility/UrlHelper.php)

Looks like that might that also be related to this issue? We're using redirect module.

Rerolled MR88 to MR135 for 8.x-1.11.