AJAX calls break on Drupal 10.2 when using restore client ip + redirect module

I'm still not sure how I feel about this - looking at my test it feels very much like core is leaving the request in a state that is likely to lead to unexpected changes (by not updating the query var on the request?)

Hmm tests only running on commit so it hasn't ran in a long time, looks like when installing via composer it needs to downgrade dependencies for psr/http-message - unrelated to this change

Took me a while to arrive to this issue after experiencing broken ajax on sites with cloudflare.

I'm not familiar with the error applying the patch but the fix and the test look fine to me.

Just my 0,03.

I have noticed problems with AJAX in media gallery about 2-3 weeks ago. I haven't find solution then, but luckily the solution was to... change a browser. Sometimes Chrome was failing with AJAX, sometimes Firefox.

Today I saw WSOD on all pages of the site 8O, so it could be BIG for some websites.

* * *

The Apache errorlog helped me to find the trace to Cloudflare and this issue.

#9 works for me. Thank you for your work!

Szy.

In my case error logs where not helpful. I had to follow the code.

One more cent: If you use https://www.drupal.org/project/trusted_reverse_proxy →
that priority also needs to be raised to 601, or you won't be restoring any IPs from cloudflare.

Thanks for the review + feedback.

I am still really undecided on this on - at the moment it feels like this is not cloudflare modules problem to solve, and given it impacts trusted_reverse_proxy as well, I don't like the idea of both modules have to carefully keep an eye on core to see if priority is ever bumped.

At the same time, I proposed to fix it in redirect module 🐛 Broken redirect from RouteNormalizerRequestSubscriber when ajax_page_state present and $request->overrideGlobals() has been called Needs review - that too is not necessarily more stable as Symfony could change the behaviour at any point to make update other vars as part of overrideGlobals.

@rodrigoaguilera and @szy - we're both your scenarios using redirect module as well? I note there are other modules using server->get('QUERY_STRING') but interested if they could have any similar impact.

Overall - I'm glad the patch works but I'm still not convince what the permanent fix is.

Yes, I use the redirect module too.

Me too.

Szy.

@ericgsmith thanks for identifying this, and for providing a fix. Merged in, and will roll a new release shortly.

Automatically closed - issue fixed for 2 weeks with no activity.