- Issue created by @Rajab Natshah
- First commit to issue fork.
- Merge request !2#3426896 Check for active theme befor altering the form. → (Merged) created by Hydra
- 🇩🇪Germany Hydra
Hey! Thanks for the nice feedback!
The revision information is actually there by default. Only the status tab is added by gin_everywhere. I believe that the workflow information are also added by default, but I am not sure about that since I did not test it yet.
I think it would be a good idea to check if we are in the context of the gin theme when enhancing the forms anyways. The MR should do the trick, feedback is welcome.
- 🇯🇴Jordan Rajab Natshah Jordan
Thank you, Pascal, for the quick follow up on the issue!!
I like your idea, "Check if we are in the context of the gin theme when enhancing the forms"that will be better, for sure
- Status changed to Needs review
9 months ago 4:43pm 10 March 2024 - 🇩🇪Germany Hydra
I would be happy to merge if you could give it a quick review and RTBC the issue :)
- Status changed to RTBC
9 months ago 5:04pm 10 March 2024 - 🇯🇴Jordan Rajab Natshah Jordan
Working!
I no longer see the vertical tab in none Gin or Sub theme of Gin.Better to use Sascha's way with
array_key_exists
as he used it in a code which he helped us with.$active_theme = \Drupal::theme()->getActiveTheme(); $base_themes = (array) $active_theme->getBaseThemeExtensions(); if (!($active_theme->getName() === 'gin' || array_key_exists('gin', $base_themes))) { }
- 🇩🇪Germany Hydra
Great suggestion, thx! I replaced my check with Sascha's code - it works perfectly :)
- Status changed to Fixed
9 months ago 5:51pm 10 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.