- Issue created by @kevinsiji
- Status changed to Postponed: needs info
10 months ago 12:40pm 7 March 2024 You reported a bug for a Webform version that is no longer supported:
No longer supported: Webform 6.1.x (for Drupal 9), Webform 6.0.x (for Drupal 9), Webform 8.x-5.x (for Drupal 8).
The bug will have to be reproduced on a supported release to be fixed.
- Status changed to Active
10 months ago 7:27pm 7 March 2024 - 🇺🇸United States paulmckibben Atlanta, GA
I was able to reproduce this issue in version 6.2.2. I'll try @kevinsiji 's fix and report back.
- last update
10 months ago 536 pass - Status changed to Needs review
10 months ago 7:45pm 7 March 2024 - 🇺🇸United States paulmckibben Atlanta, GA
I created the above merge request. The infinite loop in attachBehaviors was due to not passing the context and settings parameters to the timeout callback, causing attachBehaviors to be invoked on the document element infinitely.
- Status changed to RTBC
10 months ago 4:07am 8 March 2024 - 🇺🇸United States jrockowitz Brooklyn, NY
The change does not make sense because it triggeing the attachBehaviors immediate by calling the anonymous function with (context, settings);
// If the back button is pressed, delay Drupal's attaching of behaviors. if (backButton) { var attachBehaviors = Drupal.attachBehaviors; Drupal.attachBehaviors = function (context, settings) { setTimeout(function (context, settings) { attachBehaviors(context, settings); }(context, settings);, 300); }; }
I think the issue is that we want context and settings to be set via a closure and we need to remove the anonymous function's (context, settings) parameters.
// If the back button is pressed, delay Drupal's attaching of behaviors. if (backButton) { var attachBehaviors = Drupal.attachBehaviors; Drupal.attachBehaviors = function () { // Get context and settings via the closure. setTimeout(function (context, settings) { attachBehaviors(context, settings); }, 300); }; }
- Status changed to Needs review
9 months ago 2:33pm 4 April 2024 26:13 50:49 Running- last update
9 months ago 536 pass - Status changed to Fixed
9 months ago 1:10am 6 April 2024 -
jrockowitz →
committed ebae3640 on 6.2.x authored by
paulmckibben →
Issue #3426365 by paulmckibben, jrockowitz, kevinsiji, cilefen, Liam...
-
jrockowitz →
committed ebae3640 on 6.2.x authored by
paulmckibben →
- 🇺🇸United States jrockowitz Brooklyn, NY
The fact that this also fixes 🐛 Duplicate buttons from Dialog UI within Ajax Wizard when using Chrome/Edge browser back button Closed: duplicate makes this fairly safe to merge.
- a00f992e committed on 6.2.x
Issue #3426365 by jrockowitz, paulmckibben, kevinsiji, cilefen, Liam...
- a00f992e committed on 6.2.x
Automatically closed - issue fixed for 2 weeks with no activity.