Doesn't respect published/unpublished status of translations

m.anoune → made their first commit to this issue’s fork.

m.anoune → changed the visibility of the branch 8.x-1.x to hidden.

Hello,
MR 14 generates error

The website encountered an unexpected error. Please try again later.
Error: Class 'AccessResult' not found in unpublished_node_permissions_node_access() (line 67 of modules/contrib/unpublished_node_permissions/unpublished_node_permissions.module).

After adding missing line
use Drupal\Core\Access\AccessResult;
it seems that it works and solved the problem with translations.

Thanks

It's incorrect to fix it in that way:
- hook_entity_access doesn't work with queries and autocomplete fields. So, your changes create new bugs;
- it makes no sense to remove unpublished_node_permissions_node_grants() but still use unpublished_node_permissions_node_access_records() and rebuild node grants on module install.

you can check the difference between access hooks here - https://api.drupal.org/api/drupal/core%21modules%21node%21node.module/gr...

Yes, now it works!

We've had the same issue here and moved to https://www.drupal.org/project/view_unpublished → . That module does exacly the same thing, and is more globally used than this one.

I have been working on a patch to fix this issue. We have been testing and it seems to works fine. With this patch, the permissions are saved right on the node_access table in the database.

This patch is to 8.x-1.5 version.

Hello,
I add a small change in the patch because the code of version 1.5 changes a little. Instead of:

'realm' => 'view_unpublished_author',
'gid' => $node->getOwnerId(),

I have:

'realm' => 'view_unpublished_author',
'gid' => $node->getOwnerId() ?? 1,

Hello again,

Sorry, I realized that my difference is due to the fact that I have the patch applied as well:

https://www.drupal.org/files/issues/2024-03-11/3427115-2.patch →

I don't know if the same thing can happen to anyone.

The final patch that fixes both problems. The reason is that gid cannot be null.

Patch doesn't work for me. This makes the module unusable for me -.-