- Issue created by @gaurav_manerkar
- 🇮🇳India gaurav_manerkar Vasco Da Gama, Goa
- Status changed to Needs review
9 months ago 11:37am 5 March 2024 - 🇮🇳India gaurav_manerkar Vasco Da Gama, Goa
Fixed, see https://git.drupalcode.org/issue/opentelemetry-3425641/-/jobs/992058
Please review. - Status changed to Fixed
9 months ago 5:19am 6 March 2024 -
Murz →
committed c9a9f694 on 1.0.x authored by
gaurav_manerkar →
Issue #3425641 by gaurav_manerkar: Fix cSpell errors
-
Murz →
committed c9a9f694 on 1.0.x authored by
gaurav_manerkar →
- 🇬🇧United Kingdom jonathan1055
Hi,
Would it be OK if I used this issue to test some further enhancements to the CSPELL job in gitlab templates? I found your project through a code search on gitlab, I was looking for a project which has added a.cspell-project-words.txt
file, and where the changes would demonstrate a benefit for the project. The issue is #3426136: Execute CSPELL in project root folder and make fixing words easier → . - 🇬🇧United Kingdom jonathan1055
In https://git.drupalcode.org/project/opentelemetry/-/merge_requests/44 you can see that the additional
_CSPELL_IGNORE_PATHS: "\"composer.json\""
is not required with the new changes, as this file is now ignored by default. The job still passes green.You can leave this MR open, and when the changes are merged and gitlab_templates updated for all projects, I'll remove the testing changes here and you can commit the MR then if you want to.
Thank you for letting me use your project for testing CSpell.
- Status changed to RTBC
8 months ago 3:06pm 28 March 2024 - 🇬🇧United Kingdom jonathan1055
#3426136: Execute CSPELL in project root folder and make fixing words easier → has been committed.
Also the gitlab_templates
default-ref
tag has been updated to include this change for all contrib by default. Hence I have reverted the temporary change here.MR44 is ready for merging. It simply removes the _cspell_ignore_paths variable which you don't need anymore.
-
Murz →
committed dd025e5b on 1.0.x authored by
jonathan1055 →
Issue #3425641 by gaurav_manerkar, jonathan1055, Murz: Fix cSpell errors
-
Murz →
committed dd025e5b on 1.0.x authored by
jonathan1055 →
- Status changed to Fixed
8 months ago 5:12am 29 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.