- Issue created by @guido_s
- Merge request !5#3425468 applied coding standards to the project and added phpcs.xml β (Merged) created by guido_s
- Status changed to Needs review
10 months ago 4:43pm 4 March 2024 - π©πͺGermany guido_s Cologne
I applied coding standards to all files in the project and added a phpcs.xml for this project.
phpcs -v coookies_addons
resulted in 0 warnings and 0 errors.Project needs to be tested if nothing is broken after those code changes.
- Assigned to _shy
- Status changed to Needs work
10 months ago 8:22am 5 March 2024 - πΊπ¦Ukraine _shy Ukraine, Lutsk πΊπ¦
Still experienced some coding standard issues. I'll take a look at it.
- πΊπ¦Ukraine _shy Ukraine, Lutsk πΊπ¦
For now, I stack with ESlint check. We have
.eslintrc.json
file which is has the following line:"extends": "drupal"
This causes the following error on the ESlint job:ESLint couldn't find the config "drupal" to extend from. Please check that the name of the config is correct. The config "drupal" was referenced from the config file in "/builds/project/cookies_addons/web/modules/custom/cookies_addons/.eslintrc.json".
This file does not strictly need to exist in contrib, because eslint config files placed further up in the directory structure will be merged and inherited. The top-level .eslintrc.json extends ./core/.eslintrc.json.
- Status changed to Fixed
4 months ago 3:35pm 26 August 2024 - π©πͺGermany guido_s Cologne
I couldn't get eslint checks running as intended.
It's a known issue with extending eslint configs.
https://www.drupal.org/project/gitlab_templates/issues/3438843 βSo for now I specified another .eslintrc.json to extend.
This leads to issues when working locally on the project as this .eslintrc.json can't be found there while not used in a complete drupal setup, but at least checks are passing now.
Should be refactored in the future if a solution is found in the mentioned issue. -
Guido_S β
committed 14198653 on 1.0.x
#3425468 applied coding standards to the project and added phpcs.xml
-
Guido_S β
committed 14198653 on 1.0.x
Automatically closed - issue fixed for 2 weeks with no activity.