Add post-rector upgrade status result to issue comment

Created on 4 March 2024, about 1 year ago
Updated 3 April 2024, about 1 year ago

Problem/Motivation

In 📌 Automated Drupal 11 compatibility fixes for upgrade_status Needs work it tells me there were problems left post-rector, and I KNOW it knows what those are but they are still not disclosed. I think it would save a lot of contributor hours if the post-rector Upgrade Status results would be posted

Steps to reproduce

Proposed resolution

Post the results as an attachment with .txt extension I think.

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Component

Code

Created by

🇭🇺Hungary Gábor Hojtsy Hungary

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Gábor Hojtsy
  • 🇳🇱Netherlands bbrala Netherlands

    Oh that is a great idea. Only possible issue is that the data is currently in XML so we'd need to make that readable.

    The check if it should be posted is pretty easy i guess, the logic is already there.

  • 🇭🇺Hungary Gábor Hojtsy Hungary

    If xsltproc is available in the container, I can add a simple XSLT sheet to produce a useful output. (Way-way back in the day I used to teach XPath and XSLT in afternoon school, among others :D). Or we can read it back, and convert to ASCII table in PHP. Upgrade Status already has a standalone PHP library that can do that to PHP arrays. That may give us much nicer formatting.

  • Pipeline finished with Failed
    about 1 year ago
    Total: 547s
    #110804
  • Pipeline finished with Failed
    about 1 year ago
    Total: 573s
    #110807
  • Merge request !25Resolve #3425461 "Post rector report" → (Closed) created by Gábor Hojtsy
  • Status changed to Needs review about 1 year ago
  • 🇭🇺Hungary Gábor Hojtsy Hungary

    Proposed a potential code solution for this. :) Its not exactly the same format as the upgrade status report (the detailed category information is not available in the checkstyle XML), but otherwise it should be readable. I did not actually have a chance to test this (I don't have a setup still), so if you can run it on a test project or two, that would be fabulous :) Hope it helps to save some user pain and confusion as to why not are info files updated in some cases.

    Still todo is to update the comment text to mention this file.

  • Pipeline finished with Failed
    about 1 year ago
    Total: 547s
    #110902
  • 🇭🇺Hungary Gábor Hojtsy Hungary

    Added (also untested) code for that too. The comment should contain this bit when post-rector report is also attached:

    After the Drupal Rector fixes were applied, Upgrade Status still reported outstanding compatibility issues. Those are also attached to help you resolve them manually.

    Please review/test! :)

  • Status changed to Fixed about 1 year ago
  • 🇳🇱Netherlands bbrala Netherlands

    Fixed quite a few issues while merging, but has been merged to master-d11 Thanks!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024