- Issue created by @konstara
- Status changed to Needs review
11 months ago 1:56pm 4 March 2024 - last update
11 months ago 536 pass - Status changed to Needs work
2 months ago 9:17pm 23 November 2024 - 🇺🇸United States jrockowitz Brooklyn, NY
This needs to be rerolled for 6.3.x with test coverage.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
There is no need to close the merge request. It can be updated to point to branch 6.3.x and you can force-push the updated code to the feature branch of the merge request.
- 🇫🇮Finland konstara Helsinki
Answer to #6: I think I messed up the branch on previous merge request and it seemed to be rather cumbersome to fix. I tried to merge the 6.3.x to the branch that was based on 6.2.x so it had all the changes shown as they are coming in on my merge request as a new files and chagnes. Closed that and created new branch based on 6.3.x and added code there as it was before. Still haven't made tests, but they are coming in the near future and then I will open the request again.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
You can checkout the branch of the merge request, run
git reset --hard 6.3.x
, make your changes, thengit push --force
. That will re-use the current merge request. It will automatically create a tag pointing at the old commits so they are there to refer to. Nothing gets lost.