- Issue created by @yas
- Merge request !2247Issue #3425376 by yas: Fix PHPUnit errors: 'TypeError:... β (Merged) created by yas
- Status changed to Needs review
10 months ago 11:48pm 4 March 2024 - πΊπΈUnited States yas California πΊπΈ
@baldwinlouie
Can you please review the patch? Thanks!
- Status changed to Needs work
10 months ago 3:54am 5 March 2024 - πΊπΈUnited States baldwinlouie
@yas, I started to add comments to the code. But since my idea applies to all the changes, I will post it here.
Instead of casting the to
(string) $this->t('Save')
, would it be better to use the following$this->t('Save')->render()
?What do you think?
- Status changed to Needs review
10 months ago 5:20am 5 March 2024 - πΊπΈUnited States yas California πΊπΈ
@baldwinlouie
Thank you for your review and suggestion. I changed from casting
(string)
to using->render()
. Can you review the patch again? Thanks - Status changed to RTBC
10 months ago 5:24am 5 March 2024 - πΊπΈUnited States baldwinlouie
@yas, thank you for the updated patch. It looks good to me now.
- πΊπΈUnited States yas California πΊπΈ
@baldwinlouie
Thank you for your review. I'll merge the patch to
6.x
and7.x
, and close this issue as Fixed. - Status changed to Fixed
10 months ago 5:44am 5 March 2024 - Merge request !2252Issue #3425376 by yas: Hotfix - Fix PHPUnit errors: 'TypeError:... β (Merged) created by yas
- Status changed to RTBC
10 months ago 10:08am 5 March 2024 - πΊπΈUnited States yas California πΊπΈ
@baldwinlouie
I found there are some uncovered codes for
->render()
, so I'll merge the hotfix to7.x
, and close this issue as Fixed. - Status changed to Fixed
10 months ago 10:11am 5 March 2024 - πΊπΈUnited States yas California πΊπΈ
@baldwinlouie
I found there are some uncovered codes for
->render()
, so I'll merge the hotfix to7.x
, and close this issue as Fixed. Automatically closed - issue fixed for 2 weeks with no activity.