- Issue created by @seutje
- 🇧🇪Belgium seutje Antwerp
Attached patch moves everything within the closure, declares window as a passed variable and then attached the variables to the window object that way for both gtag.js and gtm.js. It also adds "use strict" at the top of both and removes the exclusion from preprocessing.
If there is a different reason they are excluded from preprocessing, let me know and I'll remove that part from the patch. - Status changed to Needs review
10 months ago 10:09am 4 March 2024 - last update
10 months ago Build Successful - last update
10 months ago 54 pass - last update
10 months ago 54 pass - 🇧🇪Belgium seutje Antwerp
It suddenly dawned on me that I had done a "git add ." after putting the first patch in the same folder, adding the entire first patch to the second...
Remember kids, don't write patches until you've had your coffee, or at least manually review the contents of what you're uploading.
Attached patch should be correct, also moves the "use strict" inside the closure/IIFE/whatever we're calling it nowadays.
- Status changed to Needs work
9 months ago 8:32am 4 April 2024 - 🇩🇪Germany Anybody Porta Westfalica
@seutje thanks, I think this is a good improvement, but could you please put the final changes to review into a MR here?
- First commit to issue fork.
- Merge request !79Explicitly leak to global scope instead of implicitly so strict mode and preprocessing can be used. → (Open) created by rajeshreeputra
- Status changed to Needs review
8 months ago 12:23pm 23 April 2024