- Issue created by @drunken monkey
- Assigned to samit.310@gmail.com
- Status changed to Needs work
10 months ago 9:35am 5 March 2024 - Issue was unassigned.
- Status changed to Needs review
10 months ago 7:31am 6 March 2024 - ๐ฎ๐ณIndia samit.310@gmail.com
Hi @drunken monkey,
Please review the patch.
Thanks
Samit K. - ๐ฆ๐นAustria drunken monkey Vienna, Austria
Thanks for the patch!
However, is there a reason you removedsrc/AutocompleteBackendInterface.php
? This seems quite unrelated to Drupal 11 support.Created an MR that just declares support, should be all thatโs needed. Unfortunately, we cannot properly test this until Search API and Search API Pages declare Drupal 11 support, too.
- ๐ฎ๐ณIndia samit.310@gmail.com
Hi @drunken monkey,
As search_api also have the same
AutocompleteBackendInterface
interface.modules/contrib/search_api/src/Contrib/AutocompleteBackendInterface.php
Thanks
Samit K. -
drunken monkey โ
committed dfdb0b2b on 8.x-1.x
Issue #3425236 by drunken monkey, samit.310@gmail.com: Fixed...
-
drunken monkey โ
committed dfdb0b2b on 8.x-1.x
- Status changed to Fixed
9 months ago 10:38am 13 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Postponed
8 months ago 2:28pm 21 April 2024 - ๐ฆ๐นAustria drunken monkey Vienna, Austria
Keeping this open so I remember to turn on testing against Drupal 11 once itโs available. However, still waiting on Facets ( ๐ Make module compatible with Drupal 11 Needs review ) for that.
- ๐ฆ๐นAustria drunken monkey Vienna, Austria
Turns out the Search API module itself is not ready (currently just throws fatal errors, see #3425235-12: Make the Search API module compatible with Drupal 11 โ ), so still need to wait for that, too.
I did, however, just commit the Search API Pages patch, so thatโs something. - First commit to issue fork.
- Assigned to ankitv18
- Status changed to Needs work
6 months ago 12:25pm 18 June 2024 - ๐ฎ๐ณIndia ankitv18
As search_api is released with D10.1 and D11 support, Rechecking if any work is left on this.
- ๐ฎ๐ณIndia ankitv18
ankitv18 โ changed the visibility of the branch 3425236-search-api-ready-d11 to hidden.
- ๐ฎ๐ณIndia ankitv18
ankitv18 โ changed the visibility of the branch 3425236-drupal-11-compatibility to hidden.
- Issue was unassigned.
- Status changed to Needs review
6 months ago 1:11pm 18 June 2024 -
drunken monkey โ
committed e35a5567 on 8.x-1.x authored by
ankitv18 โ
Follow-up to #3425236 by ankitv18, drunken monkey: Fixed test failures...
-
drunken monkey โ
committed e35a5567 on 8.x-1.x authored by
ankitv18 โ
- Status changed to Fixed
6 months ago 11:16am 22 June 2024 - ๐ฆ๐นAustria drunken monkey Vienna, Austria
Looks great, thanks! Just fixed the remaining fail in
SearchCrudTest
and then merged.
Thanks again! Automatically closed - issue fixed for 2 weeks with no activity.