- Issue created by @capysara
- Merge request !34Draft: Resolve #3424689 - Use Finalized version instead of last edited version for Up To Date version โ (Closed) created by capysara
- last update
10 months ago Composer require-dev failure - ๐บ๐ธUnited States capysara
capysara โ changed the visibility of the branch 3424689-media-library-thumbnail to hidden.
- ๐บ๐ธUnited States capysara
This ticket is still Active because the MR doesn't work as expected.
- ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
Balu Ertl โ made their first commit to this issueโs fork.
- Merge request !50Resolve #3424689 - Refactor asset version checking logic to rely on the 'finalized' flag instead โ (Closed) created by Balu Ertl
- Status changed to Needs review
8 months ago 2:06pm 7 May 2024 - ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
@capysara's guess of looking around at the inline comment โWe can assume, that the latest version is the last item of the arrayโ was correct. I have completely rewritten the logic of how we were deciding whether an asset has a newer version compared to what we store. Also, I opened a separate MR in the same repository for this issue so as not to override their work.
- ๐บ๐ธUnited States capysara
capysara โ changed the visibility of the branch capysara-3424689-media-library-thumbnail-patch-a1b8 to hidden.
- First commit to issue fork.
- Assigned to Balu Ertl
- ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
Balu Ertl โ changed the visibility of the branch 1.0.x to hidden.
- ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
Balu Ertl โ changed the visibility of the branch 1.1.x to hidden.
- ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
As it turned out during some manual testing, there was a third place where the latest asset version was assumed to be the final.
Now the asset version resolving logic is centralized into a separate service, which is being called from several points of the source code.
- ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
Some test scenarios of our ORCA-based pipeline break with very similar symptoms as described in #3443055-10: Handling media items when their asset gets unavailable in Widen โ .
- Status changed to Needs work
5 months ago 1:59pm 6 August 2024 - ๐ฎ๐ณIndia vishalkhode
Moving this back, as there are lots of fixes needs to done on
AssetVersionResolver
class.
- Status changed to Needs review
5 months ago 3:52pm 6 August 2024 - ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
@vishalkhode โ thank you for the thorough review of the newly added class. Indeed, multiple fixes were needed which now I done.
- ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
The remaining bug caught by the tests is fixed, the pipeline is green finally.
@vishalkhode โ I would appreciate if you would find some time to check my fixes upon your previous feedback and RTBC the issue if you find everything alright. Thanks!
-
japerry โ
committed c9d3ff3d on 1.0.x authored by
baluertl โ
Issue #3424689: Look for the "finalized" asset version not the latest...
-
japerry โ
committed c9d3ff3d on 1.0.x authored by
baluertl โ
-
japerry โ
committed c9d3ff3d on acms-4080-alternate-preview authored by
baluertl โ
Issue #3424689: Look for the "finalized" asset version not the latest...
-
japerry โ
committed c9d3ff3d on acms-4080-alternate-preview authored by
baluertl โ
-
japerry โ
committed b2b8202c on 1.1.x authored by
baluertl โ
Issue #3424689: Look for the "finalized" asset version not the latest...
-
japerry โ
committed b2b8202c on 1.1.x authored by
baluertl โ
-
japerry โ
committed b2b8202c on acms-3567-asset-importer authored by
baluertl โ
Issue #3424689: Look for the "finalized" asset version not the latest...
-
japerry โ
committed b2b8202c on acms-3567-asset-importer authored by
baluertl โ
Automatically closed - issue fixed for 2 weeks with no activity.