Remove book from d6\MigrateBlockContentTranslationTest

The book module was included in that test as part of #2225681: Migrate D6 i18n blocks translated strings → .

There is nothing specific in that issue that talks about the book module, but I can see that test executes the d6_block_translation migration which still references the book module in its static map.

I feel like we should remove the book reference from the migration too, but since tests are passing I suppose that could be done in a follow up to not block this issue.

Not changing the status to collect thoughts on removing from the migration in this issue or in a follow up.

Yes, it is true, that in the all the block migrations there are occurrences of deprecated modules. These are in a static_map process plugin and do not require the presence of the deprecated module to run. What will happen is that a block for a deprecated module will be migrated as broken. This can been seen in \Drupal\Tests\block\Kernel\Migrate\d6\MigrateBlockTest where the book related block is no 'broken', after 📌 Remove install of book module from migration tests outside of the module Fixed was fixed.

If anyone is migrating a site that uses a deprecated module, it should be installed or the contrib equivalent should be installed in order to migrate the data.

That all makes sense. IMO we should remove the book references from the migrate ymls, but I see in the parent ticket there is this step:

Do a thorough search of core for any remaining references to the Book module. If references are found, outside of the Book module, then create issues to remove the references.

I imagine any other references will be removed there. Either way tests are still passing with this change so I don't think there is any need to hold it up, I'm happy to mark this as RTBC.

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

catch → closed merge request !6802

Automatically closed - issue fixed for 2 weeks with no activity.