- Issue created by @quietone
- 🇳🇿New Zealand quietone
Searching for migration Kernel tests shows the following. Of these, only the ones that install book need to be changed. The """ indicates a file that needs to be changed.
$ grep -riw book core | grep -v "core/modules/book" | grep Kernel | grep -i Migrate | awk -F: '{print $1}' | sort -u | nl 1 core/modules/block/tests/src/Kernel/Migrate/d6/MigrateBlockContentTranslationTest.php * 2 core/modules/block/tests/src/Kernel/Migrate/d6/MigrateBlockTest.php * 3 core/modules/block/tests/src/Kernel/Migrate/d7/MigrateBlockContentTranslationTest.php 4 core/modules/comment/tests/src/Kernel/Migrate/d7/MigrateCommentEntityDisplayTest.php 5 core/modules/comment/tests/src/Kernel/Migrate/d7/MigrateCommentEntityFormDisplayTest.php 6 core/modules/comment/tests/src/Kernel/Migrate/d7/MigrateCommentFieldInstanceTest.php 7 core/modules/comment/tests/src/Kernel/Migrate/d7/MigrateCommentTypeTest.php 8 core/modules/field/tests/src/Kernel/Migrate/d7/MigrateFieldFormatterSettingsTest.php 9 core/modules/field/tests/src/Kernel/Migrate/d7/MigrateFieldInstanceTest.php 10 core/modules/field/tests/src/Kernel/Migrate/d7/MigrateFieldInstanceWidgetSettingsTest.php 11 core/modules/field/tests/src/Kernel/Migrate/d7/RollbackFieldInstanceTest.php 12 core/modules/language/tests/src/Kernel/Migrate/d7/MigrateLanguageContentSettingsTest.php 13 core/modules/migrate_drupal/tests/src/Kernel/d6/MigrateDrupal6AuditIdsTest.php * 14 core/modules/migrate_drupal/tests/src/Kernel/d7/FieldDiscoveryTest.php 15 core/modules/migrate_drupal/tests/src/Kernel/d7/MigrateDrupal7AuditIdsTest.php * 16 core/modules/migrate_drupal/tests/src/Kernel/StateFileExistsTest.php * 17 core/modules/migrate/tests/src/Kernel/Plugin/MigrationPluginListTest.php * 18 core/modules/node/tests/src/Kernel/Migrate/d7/MigrateNodeCompleteTest.php 19 core/modules/node/tests/src/Kernel/Migrate/d7/MigrateNodeTitleLabelTest.php 20 core/modules/node/tests/src/Kernel/Migrate/d7/MigrateNodeTypeTest.php 21 core/modules/user/tests/src/Kernel/Migrate/d7/MigrateUserRoleTest.php
Also to change are the Functional tests in migrate_drupal_ui.
- Status changed to Needs review
over 1 year ago 11:48am 22 July 2023 - last update
over 1 year ago 29,875 pass, 2 fail - 🇳🇿New Zealand quietone
This includes changes for the Functional tests and the Kernel tests mentioned in the previous comment.
The last submitted patch, 3: 3376262-3.patch, failed testing. View results →
- last update
over 1 year ago 29,879 pass - Status changed to RTBC
over 1 year ago 1:15pm 24 July 2023 - 🇺🇸United States smustgrave
Kind of cross reviewed with https://www.drupal.org/project/drupal/issues/3376259#comment-15163052 📌 Move book migrations tests to book module Fixed
Think I got myself confused. Almost sent back for the stuff in #3376262: Remove install of book module from migration tests outside of the module but realized they're separate.
I actually applied both patch #4 and #5 from #3376262: Remove install of book module from migration tests outside of the module for my reviewChecked migrate
1 instance has a todo to removeChecked migrate_drupal
100+ but because of the fixtures
Ignoring those the other instances have a a todoChecked migrate_drupal_ui
See 'Book' was added to all missing pathes. - last update
over 1 year ago 29,879 pass - last update
over 1 year ago 29,884 pass - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - Status changed to Needs review
over 1 year ago 8:47am 22 August 2023 - last update
over 1 year ago 30,056 pass - 🇳🇿New Zealand quietone
Needed a reroll because of 📌 Move book migrations tests to book module Fixed .
The only changes were to core/modules/block/tests/src/Kernel/Migrate/d6/MigrateBlockTest.php
- Status changed to RTBC
over 1 year ago 6:24pm 22 August 2023 - last update
over 1 year ago 30,055 pass, 1 fail The last submitted patch, 7: 3376262-7.patch, failed testing. View results →
- last update
over 1 year ago 30,060 pass - last update
over 1 year ago 30,060 pass - last update
over 1 year ago 30,098 pass - last update
over 1 year ago 30,134 pass - last update
over 1 year ago 30,135 pass - last update
over 1 year ago 30,136 pass - last update
over 1 year ago 30,136 pass - last update
over 1 year ago 30,146 pass - last update
over 1 year ago 30,148 pass - last update
over 1 year ago 30,150 pass - last update
over 1 year ago 30,161 pass - last update
over 1 year ago 30,161 pass 10:06 8:57 Running- last update
about 1 year ago 30,168 pass - last update
about 1 year ago 30,205 pass - last update
about 1 year ago 30,363 pass - last update
about 1 year ago Build Successful - last update
about 1 year ago 30,360 pass - last update
about 1 year ago 30,361 pass - last update
about 1 year ago 30,379 pass - last update
about 1 year ago 30,377 pass - last update
about 1 year ago 30,382 pass - last update
about 1 year ago 30,392 pass - last update
about 1 year ago 30,394 pass - last update
about 1 year ago 30,397 pass - last update
about 1 year ago 30,412 pass - 🇬🇧United Kingdom longwave UK
Committed and pushed 2784ef71b0 to 11.x and 7ae12d12c2 to 10.2.x. Thanks!
-
longwave →
committed 7ae12d12 on 10.2.x
Issue #3376262 by quietone, smustgrave: Remove install of book module...
-
longwave →
committed 7ae12d12 on 10.2.x
- Status changed to Fixed
about 1 year ago 10:25am 17 October 2023 -
longwave →
committed 2784ef71 on 11.x
Issue #3376262 by quietone, smustgrave: Remove install of book module...
-
longwave →
committed 2784ef71 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.