Media overwrites validation constraints

I made a patch proposal fix for this issue.

Thanks @miksha. The merge request needs to be created against 11.x (our main development branch); it will be backported to supported versions once committed to 11.x. In some cases the easiest thing to do is close the previous merge request and create a new one against 11.x.

@xjm I created https://git.drupalcode.org/project/drupal/-/merge_requests/8349

MR is 1244 commits behind.

Probably need a test case showing this issue.

larowlan → changed the visibility of the branch 3424200-media-overwrites-validation to hidden.

larowlan → changed the visibility of the branch 10.2.x to hidden.

Refactored and added tests

Left some comments on MR.

Addressed feedback. Adjusted the test to it captured the previous failing behaviour better.

Pipeline is green. Back to needs review.

All feedback appears to be addressed

Added code review with recommendations. Not sure why PHPCS is not enforcing it but 'Implements hook_' docblocks seem to be always placed just above the hook attribute of the function (i checked by grepping 'Implements hook_').

I don't see any feedback comments on the PR, maybe you didn't publish the comments?

Regarding

'Implements hook_HOOK_NAME_WHATEVER_IT_MIGHT_BE' type docblocks seem to be always placed just above the hook attribute which itself is just above the function (i checked by grepping 'Implements hook_').

I assume you're talking about the hook placement with the __invoke function? If so, this is valid. See core.api.php which describes this scenario, and CronHook in the file module for an example of how this is already implemented in cores codebase :).

Moving back to RTBC for now. Feel free to move back to NW if you have additional feedback on the PR outside of that

Re #19 Thank you @danielveza yes I had forgotten to publish. Just did but my review is not relevant: having checked the links you provide I see you are correct.

@oily Thanks for confirming!