Formatting lost when attempting to edit entity within a list item in CKEditor 5

Created on 27 February 2024, 9 months ago
Updated 21 April 2024, 7 months ago

Problem/Motivation

Steps to reproduce

Proposed resolution

port https://www.drupal.org/project/drupal/issues/3381557 🐛 [DrupalMedia] Formatting lost when attempting to edit media within a list item in CKEditor 5 Fixed

Remaining tasks

Fix test failures.

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Needs work

Version

1.0

Component

CKEditor integration

Created by

🇳🇮Nicaragua edysmp Nicaragua

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @edysmp
  • Status changed to Needs review 9 months ago
  • 🇳🇮Nicaragua edysmp Nicaragua

    the patch

  • Status changed to RTBC 9 months ago
  • 🇳🇮Nicaragua charlieweb82

    Work good, tested and the List still present when I edit the embed the patch #2 is fixed the issues

  • Status changed to Needs review 9 months ago
  • 🇳🇮Nicaragua edysmp Nicaragua

    opened a MR

  • Pipeline finished with Failed
    9 months ago
    Total: 951s
    #106235
  • Status changed to Needs work 9 months ago
  • heddn Nicaragua

    NW because of test failures.

  • 🇨🇦Canada dalin Guelph, 🇨🇦, 🌍

    Since the related Drupal Core issue was critical (because it results in data loss when upgrading from CK4), this issue should also be.

  • 🇨🇦Canada dalin Guelph, 🇨🇦, 🌍

    While this patch makes things better, I'm experiencing some significant UX issues:

    1. Create an OL
    2. Use Entity Embed button to insert a document
    3. Try to add another LI. There's no way to put your cursor after the embedded document and press . The CK5 "type around" buttons are misleading since they only add soft line breaks (i.e. keep you within the current LI)
    4. You might eventually figure out that you have to put an empty line break after the UL, and then click the OL toolbar button.

    I don't know enough about the inner workings here, but I suspect that this should be a follow-up issue.

  • First commit to issue fork.
Production build 0.71.5 2024