Slider item render issue.

Created on 27 February 2024, 4 months ago
Updated 15 March 2024, 3 months ago

Problem/Motivation

Slider item render issue when no value added in slider item in theme settings.
Codebase Drupal 10.

Steps to reproduce

1 Install the theme and set as default.
2 Go to the theme settings.
3 Update select number of slider display count into 5.
4 Go to the home page
5 Go to 4 slide in slider component.
you will find the broken slide issue.

Proposed resolution

Slide should not visible in FE when value not added

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

RTBC

Version

3.0

Component

Code

Created by

🇮🇳India Gautam_105@

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Gautam_105@
  • First commit to issue fork.
  • Merge request !11fixed slider issue → (Open) created by adarshv
  • Status changed to Needs review 4 months ago
  • 🇮🇳India adarshv

    @Drupal 8 Parallax Theme
    Fixed slider render issue. Please check above MR.

  • 🇮🇳India DishaKatariya

    Hi @adarshv I have tried by verifying the merge request !11. But the below error i have received while applying the patch.
    Error: Skipped patch 'drupal8_parallax_theme.theme'.

  • 🇮🇳India adarshv

    Hi @DishaKatariya,

    Working well on Drupal version 10 and I did not get any errors. Could you please share a screenshot?

  • 🇮🇳India DishaKatariya

    Attached the screenshot below:

  • 🇮🇳India Kanchan Bhogade

    Hi
    I've tested for MR !11 on Drupal 10
    The Patch applied successfully...

    Test Results:
    if we select the 5 slides and value is not added for the 4th and 5th slides, the Slide is not visible in FE.

    Attaching screenshots

    RTBC+1

    Keeping in "needs review" for code verification

  • Status changed to RTBC 3 months ago
  • Verified #11 patch on 10.2.x, the slides are now not visible without any content or data. Added screenshots for reference, RTBC++

Production build 0.69.0 2024