PHPCS issue breaking CI

$ vendor/bin/phpcs --config-show installed_paths Using config file: /builds/project/smart_trim/vendor/squizlabs/php_codesniffer/CodeSniffer.conf installed_paths: ../../drupal/coder/coder_sniffer,../../sirbrillig/phpcs-variable-analysis,../../slevomat/coding-standard $ vendor/bin/phpcs -i The installed coding standards are MySource, PEAR, PSR1, PSR2, PSR12, Squiz, Zend, Drupal, DrupalPractice, VariableAnalysis and SlevomatCodingStandard $ vendor/bin/phpcs -s $_WEB_ROOT/modules/custom --report-junit=junit.xml --report-full --report-summary --report-source FILE: ...builds/project/smart_trim/web/modules/custom/smart_trim/smart_trim.install -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 8 | ERROR | [x] Expected strict_types=1, found strict_types = 1. | | (SlevomatCodingStandard.TypeHints.DeclareStrictTypes.IncorrectStrictTypesFormat) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 349ms; Memory: 8MB PHP CODE SNIFFER REPORT SUMMARY -------------------------------------------------------------------------------- FILE ERRORS WARNINGS -------------------------------------------------------------------------------- ...smart_trim/web/modules/custom/smart_trim/smart_trim.install 1 0 -------------------------------------------------------------------------------- A TOTAL OF 1 ERROR AND 0 WARNINGS WERE FOUND IN 15 FILES -------------------------------------------------------------------------------- PHPCBF CAN FIX 1 OF THESE SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- PHP CODE SNIFFER VIOLATION SOURCE SUMMARY -------------------------------------------------------------------------------- SOURCE COUNT -------------------------------------------------------------------------------- [x] SlevomatCodingStandard.TypeHints.DeclareStrictTypes.IncorrectStrictTy 1 -------------------------------------------------------------------------------- A TOTAL OF 1 SNIFF VIOLATION WERE FOUND IN 1 SOURCE -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SOURCES AUTOMATICALLY (1 VIOLATIONS IN TOTAL) --------------------------------------------------------------------------------

Comments & Activities

Issue created by @markie
First commit to issue fork.
Merge request !87Adjusted strict types spacing format causing PHPCS error → (Merged) created by kurttrowbridge
Status changed to Needs review 9 months ago5:37pm 25 February 2024
Comment 9 months ago →
🇺🇸United States kurttrowbridge
(Working on this at FLDC 2024.) I'm not seeing the error when running PHPCS in the first place, so a review would definitely be appreciated, but the fix seems straightforward enough. PHPCS did not find any errors following my change either.
Pipeline finished with Success
9 months ago
Total: 270s
#103540
Comment 9 months ago →
🇺🇸United States markie Albuquerque, NM
Comment 9 months ago →
🇮🇪Ireland lostcarpark
I noticed this causing PHPCS to fail a couple of days ago.

The .install file was introduced by 📌 "More link" formatter configuration UI improvements Fixed last May, and hasn't changed since. It was added before we moved to GitLab CI, but would have been picked up by the PHPCS test when we made code quality checks stricter. I suspect this is a recent addition to the GitLab PHPCS rules.

I had a quick look at recent changes in the GitLab Templates project, but didn't notice any that appeared relevant.

Reviewed change, and it looks good, and all tests are passing with it.
Status changed to RTBC 9 months ago6:37pm 25 February 2024
Comment 9 months ago →
🇮🇪Ireland lostcarpark
Pipeline finished with Skipped
9 months ago
#103572
Comment 9 months ago →
System Message

markie → committed 9a3a1806 on 2.1.x authored by KurtTrowbridge →
Issue #3423678 by KurtTrowbridge, lostcarpark: PHPCS issue breaking CI
Status changed to Fixed 9 months ago7:48pm 25 February 2024
Comment 9 months ago →
🇺🇸United States markie Albuquerque, NM
merged. .Thanks for hopping on this at FLDC!
Comment 9 months ago →
🇮🇪Ireland lostcarpark
Confirmed this is due to a core standards change in the last month or so:
#3303206: Define a standard for adding declare(strict_types=1) →
Comment 8 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Problem/Motivation

Proposed resolution

Merge Requests

!87PHPCS issue breaking CI
Merged

Comments & Activities

PHPCS issue breaking CI

Problem/Motivation

Proposed resolution

Merge Requests

!87PHPCS issue breaking CIMerged

Comments & Activities

!87PHPCS issue breaking CI
Merged