PHPUnit warnings: mismatched function returns

Open on Drupal.org →

Created on 23 February 2024, about 1 year ago

Updated 18 April 2024, 12 months ago

Problem/Motivation

I'm running PHPUnit tests against the site and get these in the warnings report:

1x: Return type of Drupal\feeds_ex\File\LineIterator::rewind() should either be compatible with SplFileObject::rewind(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
1x in JsonPathLinesParserTest::testSimpleParsing from Drupal\Tests\feeds_ex\Unit\Feeds\Parser

1x: Return type of Drupal\feeds_ex\File\LineIterator::valid() should either be compatible with SplFileObject::valid(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
1x in JsonPathLinesParserTest::testSimpleParsing from Drupal\Tests\feeds_ex\Unit\Feeds\Parser

1x: Return type of Drupal\feeds_ex\File\LineIterator::next() should either be compatible with SplFileObject::next(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
1x in JsonPathLinesParserTest::testSimpleParsing from Drupal\Tests\feeds_ex\Unit\Feeds\Parser

Steps to reproduce

Install PHPUnit as Drupal recommends, changing the config file as needed to reflect your site path structure, and run:

phpunit --testsuite="unit"

🐛 Bug report

Status

Closed: duplicate

Component

Code

Created by

🇨🇦Canada ryanrobinson_wlu

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!23PHPUnit warnings: mismatched function returns
Open
🇺🇦Ukraine _shy
updated about 1 year ago

Comments & Activities

Issue created by @ryanrobinson_wlu
First commit to issue fork.
Merge request !23Issue #3423519: PHPUnit warnings: mismatched function returns → (Open) created by _shy
Open in Jenkins → Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7
last update about 1 year ago
113 pass
Status changed to Needs review about 1 year ago8:16am 2 March 2024
Comment about 1 year ago →
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
I also fixed a use statement, because non-namespaced classes/interfaces/traits should not be referenced with use statements.

Let's see if the tests will pass.
Comment about 1 year ago →
🇨🇦Canada ryanrobinson_wlu
I can confirm that the change worked for me. I added it as a patch to my composer, ran the tests on my local dev environment, and those warnings are no longer in the results.
Status changed to Closed: duplicate 12 months ago12:25pm 18 April 2024
Comment 12 months ago →
🇯🇵Japan ptmkenny
Closing in favor of 🐛 PHP 8.1 deprecations RTBC , which was submitted first.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024