- Issue created by @rkoller
- 🇷🇺Russia kostyashupenko Omsk
Long task.
Forced colors active disables background images and mask images.
I see only one solution -> is to rework method of rendering icons in our navigation. Instead of CSS background images we should use{{ source(path-to-icon, true) }}
and rework css accordingly - 🇷🇺Russia kostyashupenko Omsk
Any other opinions how to solve this task with minimal effort?
- 🇪🇸Spain ckrina Barcelona
We've used background images for Claro and Olivero, so they can be used :)
You can see the work done in Claro in #3130305: Ensure all of Claro's background images are visible in forced colors mode. → with a great explanation from @andrewmacpherson in comment #5 → . - Assigned to kostyashupenko
- 🇷🇺Russia kostyashupenko Omsk
holy @ckrina. It works :O
gonna dig more & maybe complete this ticket - Issue was unassigned.
- Status changed to Needs review
9 months ago 8:44am 1 April 2024 - Status changed to Needs work
9 months ago 12:01pm 1 April 2024 - 🇪🇸Spain ckrina Barcelona
Great! Could you implement it to the new styles just merged for the drawer? It's was a big MR and this has conflicts. Thanks @kostyashupenko!
- Status changed to Needs review
9 months ago 5:34am 2 April 2024 - 🇷🇺Russia kostyashupenko Omsk
Rebased, conflicts resolved. Yarn lint:css tells that there are linting problems in
toolbar-popover.pcss.css
file. However i didn't touch this file in the scope of this ticket, so should be resolved in some other issues. Current MR contains only required changes by this ticket. - Status changed to Fixed
9 months ago 7:10am 2 April 2024 - 🇩🇪Germany rkoller Nürnberg, Germany
hm i haven't noticed that the issue got in yesterday. but testing it now with the latest version of 1.x-dev in edge on macos (enable automatic dark mode ticked, forced-colors active and prefers-contrast:more) the icons, the icon within the expand and collapse button, the carrets as well as the right border of the drawer are barely visibly or invisible (in case of the right border) :/
Automatically closed - issue fixed for 2 weeks with no activity.