- Issue created by @catch
- Status changed to Needs work
11 months ago 8:03pm 22 February 2024 - π¬π§United Kingdom catch
Started an MR. Turns out we do pass empty arrays to these during tests so they need the same treatment as isValid(). Have run out of time - we still need to do the same for the trait methods.
- Status changed to Needs review
11 months ago 8:07pm 22 February 2024 - Status changed to RTBC
11 months ago 9:46pm 22 February 2024 - πΊπΈUnited States smustgrave
Geez those counts went way down!
Reviewing the change the early return seems straight forward and makes sense.
- π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
Just a small nitpick, we're returning early twice with basically the same conditions.
- π¬π§United Kingdom catch
Agreed with the nitpick and removed that change from the MR, leaving RTBC since it's just reverting a change.
- Status changed to Fixed
11 months ago 1:04pm 23 February 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Committed and pushed 08bf243d3f to 11.x and 9bc3874fce to 10.3.x. Thanks!
-
alexpott β
committed 9bc3874f on 10.3.x
Issue #3423272 by catch, kristiaanvandeneynde: Return early from more...
-
alexpott β
committed 9bc3874f on 10.3.x
-
alexpott β
committed 08bf243d on 11.x
Issue #3423272 by catch, kristiaanvandeneynde: Return early from more...
-
alexpott β
committed 08bf243d on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.