- Issue created by @bhaveshdas
- Status changed to Needs review
9 months ago 10:38am 22 February 2024 - Status changed to Needs work
9 months ago 1:56pm 22 February 2024 - šµšPhilippines clarkssquared
Hi
I applied your patch #2 and there are still PHPCS issues that were flagged in my terminal.
ā multiparagraph_flow git:(1.0.x) curl https://www.drupal.org/files/issues/2024-02-22/3423175-2.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 789 100 789 0 0 1492 0 --:--:-- --:--:-- --:--:-- 1505 patching file multiparagraph_flow.module ā multiparagraph_flow git:(1.0.x) ā .. ā contrib git:(master) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml multiparagraph_flow FILE: ...s/d9/d9-local/web/modules/contrib/multiparagraph_flow/dist/global/grid.css -------------------------------------------------------------------------------- FOUND 26 ERRORS AFFECTING 26 LINES -------------------------------------------------------------------------------- 15 | ERROR | [x] Closing brace of class definition must be on new line 19 | ERROR | [x] Closing brace of class definition must be on new line 23 | ERROR | [x] Closing brace of class definition must be on new line 27 | ERROR | [x] Closing brace of class definition must be on new line 31 | ERROR | [x] Closing brace of class definition must be on new line 35 | ERROR | [x] Closing brace of class definition must be on new line 39 | ERROR | [x] Closing brace of class definition must be on new line 43 | ERROR | [x] Closing brace of class definition must be on new line 47 | ERROR | [x] Closing brace of class definition must be on new line 51 | ERROR | [x] Closing brace of class definition must be on new line 55 | ERROR | [x] Closing brace of class definition must be on new line 59 | ERROR | [x] Closing brace of class definition must be on new line 63 | ERROR | [x] Closing brace of class definition must be on new line 67 | ERROR | [x] Closing brace of class definition must be on new line 71 | ERROR | [x] Closing brace of class definition must be on new line 75 | ERROR | [x] Closing brace of class definition must be on new line 79 | ERROR | [x] Closing brace of class definition must be on new line 83 | ERROR | [x] Closing brace of class definition must be on new line 87 | ERROR | [x] Closing brace of class definition must be on new line 91 | ERROR | [x] Closing brace of class definition must be on new line 95 | ERROR | [x] Closing brace of class definition must be on new line 99 | ERROR | [x] Closing brace of class definition must be on new line 101 | ERROR | [x] Closing brace of class definition must be on new line 104 | ERROR | [x] Closing brace of class definition must be on new line 107 | ERROR | [x] Closing brace of class definition must be on new line 113 | ERROR | [x] Closing brace of class definition must be on new line -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 26 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 195ms; Memory: 10MB ā contrib git:(master) ā
moving this to needs work
- Status changed to Needs review
9 months ago 5:41am 23 February 2024 - š®š³India bhaveshdas
fixed css issues
could you please review it.
Thankyou !!
- šŗšøUnited States MegaKeegMan
Looks like all of the errors are resolved by patch #4
Thanks for the contribution. I will have to remember to format the code as I build, especially the css, which is getting compiled via sassc
- šŗšøUnited States MegaKeegMan
MegaKeegMan ā changed the visibility of the branch 3423175-fix-the-issues to hidden.
- šŗšøUnited States MegaKeegMan
MegaKeegMan ā changed the visibility of the branch 3423175-fix-the-issues to active.
- Status changed to RTBC
9 months ago 7:52am 23 February 2024 - šŗšøUnited States MegaKeegMan
Please commit these changes to the issue fork and open a merge request
- Merge request !2multiparagraph_flow-3423175/3423175-fix-the-issues:creating mr from patch ā (Merged) created by bhaveshdas
- š®š³India bhaveshdas
As per #8 suggestion i have created MR from Patch
Thankyou!!
- šŗšøUnited States MegaKeegMan
If you use the git command at the bottom of the issue when creating your commit, Drupal credits will be applied properly. Would you like to try again using those details and then force push to the issue fork using the updated commit?
- Status changed to Fixed
9 months ago 5:50pm 25 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.