Fix the issues reported by phpcs

Created on 22 February 2024, 9 months ago
Updated 2 July 2024, 5 months ago

Problem/Motivation

FILE: /var/www/html/drupal9testing/modules/contrib/multiparagraph_flow/multiparagraph_flow.module
-------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
-------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] Missing file doc comment
  3 | ERROR   | [x] Missing function doc comment
  7 | WARNING | [x] A comma should follow the last multiline array item. Found: '/templates/paragraph'
 11 | WARNING | [x] A comma should follow the last multiline array item. Found: '/templates/field'
 12 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------

Time: 1.27 secs; Memory: 10MB

Steps to reproduce

vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,twig modules/contrib/multiparagraph_flow/

Remaining tasks

Patch Review

šŸ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Created by

šŸ‡®šŸ‡³India bhaveshdas

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @bhaveshdas
  • Status changed to Needs review 9 months ago
  • šŸ‡®šŸ‡³India bhaveshdas

    phpcs fixed all issues

    Thankyou !!

  • Status changed to Needs work 9 months ago
  • šŸ‡µšŸ‡­Philippines clarkssquared

    Hi

    I applied your patch #2 and there are still PHPCS issues that were flagged in my terminal.

    āžœ  multiparagraph_flow git:(1.0.x) curl https://www.drupal.org/files/issues/2024-02-22/3423175-2.patch | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100   789  100   789    0     0   1492      0 --:--:-- --:--:-- --:--:--  1505
    patching file multiparagraph_flow.module
    āžœ  multiparagraph_flow git:(1.0.x) āœ— ..
    āžœ  contrib git:(master) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml multiparagraph_flow
    
    FILE: ...s/d9/d9-local/web/modules/contrib/multiparagraph_flow/dist/global/grid.css
    --------------------------------------------------------------------------------
    FOUND 26 ERRORS AFFECTING 26 LINES
    --------------------------------------------------------------------------------
      15 | ERROR | [x] Closing brace of class definition must be on new line
      19 | ERROR | [x] Closing brace of class definition must be on new line
      23 | ERROR | [x] Closing brace of class definition must be on new line
      27 | ERROR | [x] Closing brace of class definition must be on new line
      31 | ERROR | [x] Closing brace of class definition must be on new line
      35 | ERROR | [x] Closing brace of class definition must be on new line
      39 | ERROR | [x] Closing brace of class definition must be on new line
      43 | ERROR | [x] Closing brace of class definition must be on new line
      47 | ERROR | [x] Closing brace of class definition must be on new line
      51 | ERROR | [x] Closing brace of class definition must be on new line
      55 | ERROR | [x] Closing brace of class definition must be on new line
      59 | ERROR | [x] Closing brace of class definition must be on new line
      63 | ERROR | [x] Closing brace of class definition must be on new line
      67 | ERROR | [x] Closing brace of class definition must be on new line
      71 | ERROR | [x] Closing brace of class definition must be on new line
      75 | ERROR | [x] Closing brace of class definition must be on new line
      79 | ERROR | [x] Closing brace of class definition must be on new line
      83 | ERROR | [x] Closing brace of class definition must be on new line
      87 | ERROR | [x] Closing brace of class definition must be on new line
      91 | ERROR | [x] Closing brace of class definition must be on new line
      95 | ERROR | [x] Closing brace of class definition must be on new line
      99 | ERROR | [x] Closing brace of class definition must be on new line
     101 | ERROR | [x] Closing brace of class definition must be on new line
     104 | ERROR | [x] Closing brace of class definition must be on new line
     107 | ERROR | [x] Closing brace of class definition must be on new line
     113 | ERROR | [x] Closing brace of class definition must be on new line
    --------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 26 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------
    
    Time: 195ms; Memory: 10MB
    
    āžœ  contrib git:(master) āœ— 

    moving this to needs work

  • Status changed to Needs review 9 months ago
  • šŸ‡®šŸ‡³India bhaveshdas

    fixed css issues

    could you please review it.

    Thankyou !!

  • šŸ‡ŗšŸ‡øUnited States MegaKeegMan

    Looks like all of the errors are resolved by patch #4

    Thanks for the contribution. I will have to remember to format the code as I build, especially the css, which is getting compiled via sassc

  • šŸ‡ŗšŸ‡øUnited States MegaKeegMan

    MegaKeegMan ā†’ changed the visibility of the branch 3423175-fix-the-issues to hidden.

  • šŸ‡ŗšŸ‡øUnited States MegaKeegMan

    MegaKeegMan ā†’ changed the visibility of the branch 3423175-fix-the-issues to active.

  • Status changed to RTBC 9 months ago
  • šŸ‡ŗšŸ‡øUnited States MegaKeegMan

    Please commit these changes to the issue fork and open a merge request

  • šŸ‡®šŸ‡³India bhaveshdas

    As per #8 suggestion i have created MR from Patch

    Thankyou!!

  • šŸ‡ŗšŸ‡øUnited States MegaKeegMan

    If you use the git command at the bottom of the issue when creating your commit, Drupal credits will be applied properly. Would you like to try again using those details and then force push to the issue fork using the updated commit?

  • Status changed to Fixed 9 months ago
  • šŸ‡ŗšŸ‡øUnited States MegaKeegMan
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024