- Issue created by @prem suthar
- ๐ฎ๐ณIndia prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
i have fixed the phpcs issues please review it .
- Status changed to Needs review
9 months ago 10:17am 21 February 2024 - Status changed to RTBC
9 months ago 10:03am 23 February 2024 - ๐ต๐ญPhilippines clarkssquared
Hi
I applied patch #2 and I confirmed that it fixes all the PHPCS issues of the module
โ entity_holder git:(1.0.x) curl https://www.drupal.org/files/issues/2024-02-21/3422897-2.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 5432 100 5432 0 0 10613 0 --:--:-- --:--:-- --:--:-- 10756 patching file entity_holder.services.yml patching file 'src/Controller/EntityHolderController.php' patching file 'src/EntityHolderStorage.php' patching file 'src/Form/EntityHolderForm.php' โ entity_holder git:(1.0.x) โ .. โ contrib git:(master) โ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml entity_holder โ contrib git:(master) โ
- ๐ช๐ธSpain manuel.adan ๐
manuel.adan โ made their first commit to this issueโs fork.
- ๐ช๐ธSpain manuel.adan ๐
manuel.adan โ changed the visibility of the branch 3422897-fix-the-issues to hidden.
- ๐ช๐ธSpain manuel.adan ๐
Created 3422897-coding_standards issue branch from the static patch file 3422897-2.patch.
Several reviews on top on that, ready to merge.
-
manuel.adan โ
committed 1de5cfa4 on 1.0.x
Issue #3422897 by Prem Suthar, manuel.adan: Fix the issues reported by...
-
manuel.adan โ
committed 1de5cfa4 on 1.0.x
- Status changed to Fixed
8 months ago 9:58am 3 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.