Convert CookiesKnockOutService in service

Thanks @cbccharlie nice work! Green lights from my side, this totally makes sense code-wise! :)
Now this needs a rebase and someone should ensure that this doesn't cause regressions or side-effects (while I don't expect them).

Thank you! I think we should get this merged soon.

cbccharlie → changed the visibility of the branch 3422880-convert-cookiesknockoutservice-in-service to hidden.

Thanks @anybody, rebase done. Change to "needs review" for whoever can review it.

Works great! And code looks perfectly fine!

RTBC!

Fixed. Thank you!

Hey Julian,
Hey Joshua,

this change is a breaking change cause of the deletion of CookiesKnockOutService::getInstance()
With the latest release of COOKiES you broke all remote implementations like eTracker's COOKiES support.

This was the default call to knock-out the scripts by server response.
CookiesKnockOutService::getInstance()->doKnockOut()

see: https://git.drupalcode.org/project/etracker/-/blob/8.x-3.x/modules/cooki...

Do you see any chance to get back the deleted method? Otherwise all remote implementations stay broke.

@sunlix, ouch...

My apologies... quick fix coming ASAP!

Reintroduced them with proper deprecation notices: https://git.drupalcode.org/project/cookies/-/commit/8aedffb838dd7308f4a2...

Appreciate the fast reaction @sunlix! I think we both slept a bit on this issue... 😅

Thank you for the quick correction and sorry for the problems caused. I forgot about the third party integrations. :(

Thanks for the quick fix @Grevil!

In the meantime, the deprecated call could use the service itself perhaps? So we can simplify the code a bit already?

But that's not urgent and just nice to have.

+1 to what @anybody comments, I think it would be a good idea.

@Anybody, yea that would be a possibility, but I guess it is fine as is for now. Let's not spent further time on this.

Automatically closed - issue fixed for 2 weeks with no activity.