- Issue created by @jcontreras
- last update
10 months ago 54 pass - Issue was unassigned.
- Status changed to RTBC
9 months ago 7:50am 8 April 2024 - 🇮🇳India abhishek_virasat
I cloned the repository from the mentioned version and verified it locally, Its working fine for me, moving RTBC++
- 🇭🇺Hungary djg_tram
Could we urge acceptance of the MR? A WSOD is, after all, quite serious a problem...
- 🇩🇪Germany Anybody Porta Westfalica
I can confirm the error and WSOD! Please merge this and tag a new release asap! Thank you!
I'll add a similar MR fixing code style and solving this a bit shorter. Maintainer may decide which approach is better, but this definitely needs to be more defensive!
- 🇩🇪Germany Anybody Porta Westfalica
Just saw that there are various other cases with similar calls. On it!
- 🇩🇪Germany Anybody Porta Westfalica
Please note that
$item->getPrice()
may also return NULL:
@return \Drupal\commerce_price\Price|null — The price, or NULL.
For that reason, I also changed
protected function formatPriceNumber(?Price $price): string {
to accept null values and return 0.00 then! Otherwise, I think me might run into the next issue, if
$price
is NULL somewhere? Hope I wasn't too defensive now. - Merge request !100Issue #3422723: Call to a member function getCurrencyCode() on null → (Open) created by Anybody
- 🇩🇪Germany Anybody Porta Westfalica
🐛 AddToCartEvent WSOD for order items with no price Active is similar, but not the same. Should be merged afterwards.