- Issue created by @gaurav_manerkar
- Merge request !40Issue #3422535: Updated spankind for root and request spans → (Merged) created by gaurav_manerkar
- Status changed to Needs review
10 months ago 4:43am 20 February 2024 - 🇦🇲Armenia murz Yerevan, Armenia
Sounds strange, but looks good :) Implementation is ok, left a comment in the MR.
-
Murz →
committed 71d3a1ef on 1.0.x authored by
gaurav_manerkar →
Issue #3422535 by gaurav_manerkar, Murz: Update SpanKind for root span
-
Murz →
committed 71d3a1ef on 1.0.x authored by
gaurav_manerkar →
- Status changed to Fixed
10 months ago 7:32am 20 February 2024 - Merge request !41Issue #3422535: Updated spankind for settings form → (Merged) created by gaurav_manerkar
- 🇮🇳India gaurav_manerkar Vasco Da Gama, Goa
MR for config settings form
https://git.drupalcode.org/project/opentelemetry/-/merge_requests/41 -
Murz →
committed 16f97971 on 1.0.x authored by
gaurav_manerkar →
Issue #3422535 by gaurav_manerkar, Murz: Update SpanKind for root span
-
Murz →
committed 16f97971 on 1.0.x authored by
gaurav_manerkar →
- Status changed to Needs review
10 months ago 8:49am 23 February 2024 Im not agree with this development, only external calls should be marked as span client. In your first reference check comment "//a guzzle middleware to wrap http calls in a span, and inject trace headers" and check official documentations about span kinds https://opentelemetry.io/docs/concepts/signals/traces/#client this development is not correct in my opinion.
- 🇮🇳India gaurav_manerkar Vasco Da Gama, Goa
Thanks @tarikflz for sharing. In that case we can switch from spankind "client" to default spankind "internal" for "RequestTraceEventSubscriber" span
I will prepare MR and will ask for review. - 🇮🇳India gaurav_manerkar Vasco Da Gama, Goa
gaurav_manerkar → changed the visibility of the branch 3422535-update-spankind-for-settings-form to hidden.
- 🇮🇳India gaurav_manerkar Vasco Da Gama, Goa
gaurav_manerkar → changed the visibility of the branch 3422535-update-spankind-for-settings-form to active.
- Merge request !42Issue #3422535: Updated spankind to default for inner requests spans → (Merged) created by gaurav_manerkar
- 🇮🇳India gaurav_manerkar Vasco Da Gama, Goa
@tarikflz please review
MR - https://git.drupalcode.org/project/opentelemetry/-/merge_requests/42 Its okey for me @gaurav_manerkar, If we are on the same page about usage of span kinds.
-
Murz →
committed 2a65db13 on 1.0.x authored by
gaurav_manerkar →
Issue #3422535 by gaurav_manerkar, Murz: Update SpanKind for root span
-
Murz →
committed 2a65db13 on 1.0.x authored by
gaurav_manerkar →
- Status changed to Fixed
10 months ago 1:08pm 26 February 2024 - 🇦🇲Armenia murz Yerevan, Armenia
Looks good for me, even better than the first version! :) Thanks, merged.
Automatically closed - issue fixed for 2 weeks with no activity.