<nolink> menu items are rendered as links.

Merge request created that updates the navbar_nav pattern.

To validate:

• Apply the change.
• Create a main menu link that the URL is <nolink>
• Save
• View the menu source and verify the menu item is wrapped in a <span> and no longer an <a>

@thejimbirch, thanks for the bug report and the MR.

@pdureau, I have assigned it to you to get your feedback after my code review. Then I will implement the solution.

Discussed with @pdureau.

No button case to handle. Printing link_attributes. I will test for navbar-text automatic or not. In favor of not placed automatically if no visual difference.

Grimreaper → credited pdureau → .

link_attributes rendered.

No need to add the navbar-text class automatically as it only change the text color. But as you can on the screenshot, it is not aligned with normal links.

So I would say if someone wants to have a nolink or a button, he/she is able to add additional classes using menu_link_attributes or something else.

@thejimbirch, I let you test the MR before merging. I will merge on thursday, in 2 days if no feedback is provided.

Code looks good. Nice catch with the attributes.

Marking RTBC

Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.