- Issue created by @thejimbirch
- Status changed to Needs review
10 months ago 3:35pm 18 February 2024 - πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Merge request created that updates the navbar_nav pattern.
To validate:
- Apply the change.
- Create a main menu link that the URL is
<nolink>
- Save
- View the menu source and verify the menu item is wrapped in a
<span>
and no longer an<a>
- Assigned to Grimreaper
- Assigned to pdureau
- Status changed to Needs work
10 months ago 12:43pm 19 February 2024 - π«π·France Grimreaper France π«π·
@thejimbirch, thanks for the bug report and the MR.
@pdureau, I have assigned it to you to get your feedback after my code review. Then I will implement the solution.
- π«π·France Grimreaper France π«π·
Discussed with @pdureau.
No button case to handle. Printing link_attributes. I will test for navbar-text automatic or not. In favor of not placed automatically if no visual difference.
- Assigned to Grimreaper
- Issue was unassigned.
- Status changed to Needs review
10 months ago 2:55pm 19 February 2024 - π«π·France Grimreaper France π«π·
link_attributes rendered.
No need to add the navbar-text class automatically as it only change the text color. But as you can on the screenshot, it is not aligned with normal links.
So I would say if someone wants to have a nolink or a button, he/she is able to add additional classes using menu_link_attributes or something else.
@thejimbirch, I let you test the MR before merging. I will merge on thursday, in 2 days if no feedback is provided.
- Status changed to RTBC
10 months ago 12:40pm 21 February 2024 - πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Code looks good. Nice catch with the attributes.
Marking RTBC
Thanks!
-
Grimreaper β
committed f9ead9c0 on 5.0.x authored by
thejimbirch β
Issue #3422210 by thejimbirch, Grimreaper, pdureau: <nolink> menu items...
-
Grimreaper β
committed f9ead9c0 on 5.0.x authored by
thejimbirch β
- Status changed to Fixed
10 months ago 4:15pm 21 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.