Contrib.social

[PP-2] Make FilterFormat config entities fully validatable

Open on Drupal.org →
Created on 16 February 2024, 9 months ago
Updated 7 March 2024, 8 months ago

Problem/Motivation

$ ./vendor/bin/drush config:inspect --filter-keys=filter.format.basic_html
➜  🤖 Analyzing…

 Legend for Data: 
  ✅❓  → Correct primitive type, detailed validation impossible.
  ✅✅  → Correct primitive type, passed all validation constraints.
 -------------------------- --------- ------------- ------ 
  Key                        Status    Validatable   Data  
 -------------------------- --------- ------------- ------ 
  filter.format.basic_html   Correct   69%           ✅❓  
 -------------------------- --------- ------------- ------

Before posting the output of

$ ./vendor/bin/drush config:inspect --filter-keys=filter.format.basic_html --detail --list-constraints  --fields=key,validatability,constraints

here, we should land:

  1. 📌 `type: filter.format.*` duplicates the inherited `dependencies` key Fixed
  2. 📌 Deprecate the 'roles' property of text formats Needs review
  3. 📌 Remove disabled filters from text format configuration Needs work
  4. ✨ Create a schema for "allowed_html" which provides a better config diff Needs work
  5. (and ideally also 🐛 [PP-1] FilterFormat should add the roles as config dependencies Postponed , which itself is blocked on 📌 Deprecate the 'roles' property of text formats Needs review )

Steps to reproduce

  1. Get a local git clone of Drupal core 11.x.
  2. composer require drupal/config_inspector — or manually install https://www.drupal.org/project/config_inspector/releases/2.1.5 → or newer (which supports Drupal 11!)
  3. composer require drush/drush
  4. vendor/bin/drush config:inspect --filter-keys=filter.format.basic_html --detail --list-constraints

Proposed resolution

  1. Add validation constraints to type: filter.format.*.
  2. Add validation constraints to type: filter and others that are still lacking validation constraints that directly block text formats from being valdiatable.
  3. Mark FullyValidatable.

Remaining tasks

TBD

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

📌 Task
Status

Postponed

Version

11.0 🔥

Component
Filter  →

Last updated about 2 hours ago

No maintainer
Created by

🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024