hamburger menu is not working

Created on 16 February 2024, 10 months ago
Updated 10 September 2024, 3 months ago

Problem/Motivation

mobile menu not working

Steps to reproduce

1) Install the theme and set as default .
2) See the theme in mobile view .
3) Found that the mobile menu is not working.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

šŸ› Bug report
Status

Needs work

Version

3.0

Component

Code

Created by

šŸ‡®šŸ‡³India Gautam_105@

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Gautam_105@
  • First commit to issue fork.
  • Merge request !12fixed hamburger-menu ā†’ (Open) created by adarshv
  • Status changed to Needs review 10 months ago
  • šŸ‡®šŸ‡³India adarshv

    @Bank Zymphonies Theme

    Fixed hamburger menu issue. Please check MR above.

  • Hi, After applying MR 12, I noticed that the hamburger menu now opens correctly when clicked. However, the first menu item is not fully visible when the menu initially opens; it only appears properly when I scroll. I've attached a screenshot of the issue for reference.

  • Status changed to Needs work 3 months ago
  • šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi @adarshv,

    Thank you for providing an MR.

    After I installed the theme and set it to default, the hamburger menu is not working. However, you can still open the menu when you click either the top or bottom space.

    Upon further testing, I noticed that this issue will only happen in logged-in users. I think this is because of the edit button

    I then applied MR!12 and it fixed the issue.

    āžœ  bank_zymphonies_theme git:(3.0.1) curl https://git.drupalcode.org/project/bank_zymphonies_theme/-/merge_requests/12.diff | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100 34906    0 34906    0     0  91549      0 --:--:-- --:--:-- --:--:-- 91616
    patching file css/global.css
    patching file sass/_menu.scss
    āžœ  bank_zymphonies_theme git:(3.0.1) āœ—

    Issues/Concerns noticed

    1. When the menu is first opened and you are on the top portion of the page, the first menu will overlap with the admin toolbars.
    2. When you click outside the area of the menu, it will not close. It would be great if the user will not depend solely in the "x" button.
      Please see video: Issue 2
    3. When a link has a sublink, it will lose its purpose as a link. It will also be unresponsive after several clicks.
      Please see video: Issue 3

    To replicate issue #3:

    1. Go to Structure > Menus
    2. Add a menu with a link that has sublinks
    3. Go to Structure > Block Layout
    4. Add the menu in the Primary Menu region (Make sure to enable the expand all menu links option)
    5. Save
    6. Go to homepage
    7. Resize page until hamburger menu will display
    8. Click on the hamburger menu
    9. Click on either the link text or the space between the link text and the "+" sign.
    10. Notice that the menu will be unresponsive afterwards.

    Please check and advise.
    Thank you.

Production build 0.71.5 2024