- Issue created by @Gautam_105@
- First commit to issue fork.
- Status changed to Needs review
10 months ago 10:00am 12 March 2024 - š®š³India adarshv
@Bank Zymphonies Theme
Fixed hamburger menu issue. Please check MR above.
Hi, After applying MR 12, I noticed that the hamburger menu now opens correctly when clicked. However, the first menu item is not fully visible when the menu initially opens; it only appears properly when I scroll. I've attached a screenshot of the issue for reference.
- Status changed to Needs work
3 months ago 8:46am 10 September 2024 - šµšPhilippines cleavinjosh
Hi @adarshv,
Thank you for providing an MR.
After I installed the theme and set it to default, the hamburger menu is not working. However, you can still open the menu when you click either the top or bottom space.
Upon further testing, I noticed that this issue will only happen in logged-in users. I think this is because of the edit button
I then applied MR!12 and it fixed the issue.
ā bank_zymphonies_theme git:(3.0.1) curl https://git.drupalcode.org/project/bank_zymphonies_theme/-/merge_requests/12.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 34906 0 34906 0 0 91549 0 --:--:-- --:--:-- --:--:-- 91616 patching file css/global.css patching file sass/_menu.scss ā bank_zymphonies_theme git:(3.0.1) ā
Issues/Concerns noticed
- When the menu is first opened and you are on the top portion of the page, the first menu will overlap with the admin toolbars.
- When you click outside the area of the menu, it will not close. It would be great if the user will not depend solely in the "x" button.
Please see video: Issue 2 - When a link has a sublink, it will lose its purpose as a link. It will also be unresponsive after several clicks.
Please see video: Issue 3
To replicate issue #3:
- Go to Structure > Menus
- Add a menu with a link that has sublinks
- Go to Structure > Block Layout
- Add the menu in the Primary Menu region (Make sure to enable the expand all menu links option)
- Save
- Go to homepage
- Resize page until hamburger menu will display
- Click on the hamburger menu
- Click on either the link text or the space between the link text and the "+" sign.
- Notice that the menu will be unresponsive afterwards.
Please check and advise.
Thank you. - When the menu is first opened and you are on the top portion of the page, the first menu will overlap with the admin toolbars.