- Issue created by @mstrelan
- Status changed to Needs review
7 months ago 6:27am 16 February 2024 - Status changed to Needs work
7 months ago 8:14am 16 February 2024 - 🇳🇱Netherlands Spokje
Drupal\KernelTests\Core\Plugin\DefaultPluginManagerTest
disagrees ;) - 🇦🇺Australia mstrelan
So apparently this sniff doesn't detect use of the variable in
finally
clauses. That seems like a bug with the sniff. That said, it seems weird to access the exception from the finally clause, because it's not guaranteed to be set. - Status changed to Postponed
7 months ago 9:18am 16 February 2024 - 🇦🇺Australia mstrelan
Looked closer at the test.
$e
is set toNULL
in thetry
clause and should become aThrowable
in thecatch
, so it should definitely exist infinally
.I guess this is postponed on False positive SlevomatCodingStandard.Exceptions.RequireNonCapturingCatch.NonCapturingCatchRequired.
- Status changed to Needs work
6 months ago 11:25pm 10 March 2024 - 🇦🇺Australia mstrelan
Issue mentioned in #6 is fixed now and released in slevomat/coding-standard:8.15.0
- Status changed to Needs review
2 months ago 3:06am 5 July 2024 - 🇦🇺Australia mstrelan
Slevomat coding standard was updated in #3262874: Update Coder to 8.3.15 → . Rebased and re-ran phpcbf. Back to Needs Review.
- 🇳🇱Netherlands Spokje
I think you've beaten Moriarty @mstrelan!
Since this adds a PHPCS-rule and might break contrib/external-CI in some places, I think we need a CR for this.
Besides that, I'm all for RTBC. - 🇦🇺Australia mstrelan
Contrib doesn't use the phpcs file from core, but we could indeed add a CR regardless.
- 🇦🇺Australia mstrelan
I don't see CR's for the latest 3 commits to phpcs.xml.dist, so maybe we're ok?
📌 Fix Drupal.Commenting.DocCommentLongArraySyntax coding standard Needs work
📌 Fix 'Drupal.Commenting.TodoComment' coding standard Needs work
📌 [PHP 8.4] Fix implicitly nullable type declarations ActiveAlso in #3180696-89: Fix 'Drupal.Commenting.TodoComment' coding standard → @quietone mentioned CR is not needed.
- Status changed to RTBC
2 months ago 5:13am 8 July 2024 - 🇳🇱Netherlands Spokje
Thanks sherlock mstrelan, seems like it's indeed not needed.
RTBC for me. - 🇬🇧United Kingdom catch
Yes core's phpcs only affects core afaik, so we don't need a CR for these. Committed/pushed to 11.x, thanks!
- Status changed to Fixed
about 2 months ago 11:52am 17 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.