Remove unused variables in catch statements

Drupal\KernelTests\Core\Plugin\DefaultPluginManagerTest disagrees ;)

So apparently this sniff doesn't detect use of the variable in finally clauses. That seems like a bug with the sniff. That said, it seems weird to access the exception from the finally clause, because it's not guaranteed to be set.

Looked closer at the test. $e is set to NULL in the try clause and should become a Throwable in the catch, so it should definitely exist in finally.

I guess this is postponed on False positive SlevomatCodingStandard.Exceptions.RequireNonCapturingCatch.NonCapturingCatchRequired.

Thanks for the Sherlocking @mrstrelan!

Elementary!

Issue mentioned in #6 is fixed now and released in slevomat/coding-standard:8.15.0

Slevomat coding standard was updated in #3262874: Update Coder to 8.3.15 → . Rebased and re-ran phpcbf. Back to Needs Review.

I think you've beaten Moriarty @mstrelan!

Since this adds a PHPCS-rule and might break contrib/external-CI in some places, I think we need a CR for this.
Besides that, I'm all for RTBC.

Contrib doesn't use the phpcs file from core, but we could indeed add a CR regardless.

I don't see CR's for the latest 3 commits to phpcs.xml.dist, so maybe we're ok?

📌 Fix Drupal.Commenting.DocCommentLongArraySyntax coding standard Needs work
📌 Fix 'Drupal.Commenting.TodoComment' coding standard Needs work
📌 [PHP 8.4] Fix implicitly nullable type declarations Active

Also in #3180696-89: Fix 'Drupal.Commenting.TodoComment' coding standard → @quietone mentioned CR is not needed.

Thanks sherlock mstrelan, seems like it's indeed not needed.
RTBC for me.

Yes core's phpcs only affects core afaik, so we don't need a CR for these. Committed/pushed to 11.x, thanks!

catch → closed merge request !6636

Automatically closed - issue fixed for 2 weeks with no activity.