Fix pipeline stuff

tonytheferg → changed the visibility of the branch 3421365- to hidden.

I have got these errors after running phpcs command

Looks like new static can be https://www.drupal.org/docs/develop/development-tools/phpstan/handling-u... →

Here's what's left:

 ------ ---------------------------------------------------------------------- 
  Line   src/Access/ProductVadoGroupAccessCheck.php                            
 ------ ---------------------------------------------------------------------- 
  39     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   src/EventSubscriber/VadoEventSubscriber.php                           
 ------ ---------------------------------------------------------------------- 
  195    \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   src/Form/VadoGroupForm.php                                            
 ------ ---------------------------------------------------------------------- 
  99     Method Drupal\commerce_vado\Form\VadoGroupForm::save() should return  
         int but return statement is missing.                                  
 ------ ---------------------------------------------------------------------- 
 ------ -------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/Commerce/VadoGroupWidget/VadoGroupWidgetBase.php                                       
 ------ -------------------------------------------------------------------------------------------------- 
  55     Method                                                                                            
         Drupal\commerce_vado\Plugin\Commerce\VadoGroupWidget\VadoGroupWidgetBase::setParentEntity()       
         should return                                                                                     
         $this(Drupal\commerce_vado\Plugin\Commerce\VadoGroupWidget\VadoGroupWidgetBase)                   
         but return statement is missing.                                                                  
  62     Method                                                                                            
         Drupal\commerce_vado\Plugin\Commerce\VadoGroupWidget\VadoGroupWidgetBase::setSelectedVariation()  
         should return                                                                                     
         $this(Drupal\commerce_vado\Plugin\Commerce\VadoGroupWidget\VadoGroupWidgetBase)                   
         but return statement is missing.                                                                  
  175    \Drupal calls should be avoided in classes, use dependency injection                              
         instead                                                                                           
  195    \Drupal calls should be avoided in classes, use dependency injection                              
         instead                                                                                           
  195    \Drupal calls should be avoided in classes, use dependency injection                              
         instead                                                                                           
  400    \Drupal calls should be avoided in classes, use dependency injection                              
         instead                                                                                           
 ------ -------------------------------------------------------------------------------------------------- 

I think most of this is probably handled by ignoring these warnings. See what commerce did here:
https://git.drupalcode.org/project/commerce/-/blob/8.x-2.x/phpstan.neon?...

Basically, the only stuff that got overlooked in ignoring errors are these dependency injection issues.

------ ---------------------------------------------------------------------- 
  Line   src/Access/ProductVadoGroupAccessCheck.php                            
 ------ ---------------------------------------------------------------------- 
  39     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   src/EventSubscriber/VadoEventSubscriber.php                           
 ------ ---------------------------------------------------------------------- 
  195    \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   src/Plugin/Commerce/VadoGroupWidget/VadoGroupWidgetBase.php                                       
 ------ --------------------------------------------------------------------------------------------------                                                   
  175    \Drupal calls should be avoided in classes, use dependency injection                              
         instead                                                                                           
  195    \Drupal calls should be avoided in classes, use dependency injection                              
         instead                                                                                           
  195    \Drupal calls should be avoided in classes, use dependency injection                              
         instead                                                                                           
  400    \Drupal calls should be avoided in classes, use dependency injection                              
         instead                                                                                           
 ------ -------------------------------------------------------------------------------------------------- 

The only thing left hiding would be this:

------ ---------------------------------------------------------------------- 
  Line   src/Access/ProductVadoGroupAccessCheck.php                            
 ------ ---------------------------------------------------------------------- 
  39     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 

Couldn't really find examples in Core of them using DI for Entity Query, so maybe we can leave that one be.

I ran the command for the baseline:

../../../../vendor/bin/phpstan analyse --level 7   --configuration phpsta
n.neon   src/ tests/ --generate-baseline

and got:
[OK] Baseline generated with 327 errors.

Some of which were fixed. Need to know more about the how and what there...

Added the baseline at level one after removing ignore for dependency injection.

Seems good to me for now. See if the pipeline agrees.

Yeah, the baseline should be generated based on the level we are running which is NOT 7. :)
That txt file is for level 7. The command to generate the baseline for level 1 is:

../../../../vendor/bin/phpstan analyse --level 1   --configuration phpsta
n.neon   src/ tests/ --generate-baseline

stepping back to vendor from the commerce_vado directory.

I think we want to know about unused ignores for now...
https://phpstan.org/user-guide/ignoring-errors#reporting-unused-ignores

Here it is in patch form.

Automatically closed - issue fixed for 2 weeks with no activity.