only require gtag.ajax library if it is needed

Created on 14 February 2024, 10 months ago

Updated 12 September 2024, 3 months ago

Problem/Motivation

As soon as this module is enabled all pages require jQuery which is because:

google_tag/gtag.ajax requires core/drupal.ajax requires core/jquery.

This requirement is only necessary when when there a specific page actually contains asynchronous elements.

Proposed resolution

Rather then attatching gtag.ajax every time in hook_page_attachments it should be attached only if some other module requires core/drupal.ajax.

✨ Feature request

Status

Active

Version

2.0

Component

Code

Created by

🇩🇪Germany loominade

Live updates comments and jobs are added and updated live.

Merge Requests

!94only require gtag.ajax library if it is needed
Open
🇺🇸United States trackleft2
updated 3 months ago

Comments & Activities

Issue created by @loominade
Comment 9 months ago →
🇩🇪Germany Anybody Porta Westfalica
Totally makes sense! Here's the 8.x-1.x issue: ✨ Remove jQuery dependency Active

Happy to review a MR to fix this.
First commit to issue fork.
First commit to issue fork.
Merge request !94Resolve #3421335 "Only require gtag.ajax if other ajax libs are added." → (Open) created by trackleft2
Pipeline finished with Failed
3 months ago
Total: 206s
#281652
Pipeline finished with Canceled
3 months ago
Total: 31s
#286386
Pipeline finished with Failed
3 months ago
#286387

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024

only require gtag.ajax library if it is needed

Problem/Motivation

Proposed resolution

Merge Requests

!94only require gtag.ajax library if it is neededOpen

Comments & Activities

!94only require gtag.ajax library if it is needed
Open