- Issue created by @SKAUGHT
- First commit to issue fork.
- 🇨🇦Canada danrod Ottawa
I'm looking on this issue at the moment.
I was thinking of making ths module Bootstrap agnostic but this would take me a LOT of time and I don't want to reinvent the wheel, and there is already a project that can be forked to support BS5. I'm also thinking of creating a different branch for the BS5 module.
- 🇨🇦Canada danrod Ottawa
I added the bootstrap dependencies at composer.json and *.info.yml and in turns I get a bunch ugly tests errors:
$ ./vendor/bin/phpunit -c web/core/phpunit.xml ./web/modules/contrib/languages_dropdown/tests/src/Functional/LanguagesDropdownAdminTest.php PHPUnit 10.5.45 by Sebastian Bergmann and contributors. Runtime: PHP 8.3.19 Configuration: /var/www/html/web/core/phpunit.xml FFFFF 5 / 5 (100%) Time: 00:29.620, Memory: 6.00 MB There were 5 failures: 1) Drupal\Tests\languages_dropdown\Functional\LanguagesDropdownAdminTest::testLoadSite Unable to install modules node, locale, language, block, bootstrap3, languages_dropdown due to missing modules bootstrap3. /var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:505 /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:555 /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367 /var/www/html/web/modules/contrib/languages_dropdown/tests/src/Functional/LanguagesDropdownAdminTest.php:35 2) Drupal\Tests\languages_dropdown\Functional\LanguagesDropdownAdminTest::testAdminUser Unable to install modules node, locale, language, block, bootstrap3, languages_dropdown due to missing modules bootstrap3. /var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:505 /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:555 /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367 /var/www/html/web/modules/contrib/languages_dropdown/tests/src/Functional/LanguagesDropdownAdminTest.php:35 3) Drupal\Tests\languages_dropdown\Functional\LanguagesDropdownAdminTest::testLanguageDropdownBlock Unable to install modules node, locale, language, block, bootstrap3, languages_dropdown due to missing modules bootstrap3. /var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:505 /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:555 /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367 /var/www/html/web/modules/contrib/languages_dropdown/tests/src/Functional/LanguagesDropdownAdminTest.php:35 4) Drupal\Tests\languages_dropdown\Functional\LanguagesDropdownAdminTest::testBlockVisibility Unable to install modules node, locale, language, block, bootstrap3, languages_dropdown due to missing modules bootstrap3. /var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:505 /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:555 /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367 /var/www/html/web/modules/contrib/languages_dropdown/tests/src/Functional/LanguagesDropdownAdminTest.php:35 5) Drupal\Tests\languages_dropdown\Functional\LanguagesDropdownAdminTest::testAdminUserAfterChanges Unable to install modules node, locale, language, block, bootstrap3, languages_dropdown due to missing modules bootstrap3. /var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:505 /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:555 /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367 /var/www/html/web/modules/contrib/languages_dropdown/tests/src/Functional/LanguagesDropdownAdminTest.php:35
So I'll skip adding the dependencies because I don't see a point in installing a whole theme if the user doesn't intend to use it, I'll continue to use the libraries.yml file to add the BS dependencies, but I'll create another branch for the BS5 support.
I made some extra fixes in the .gitlab-ci.yml and composer.json file so I'll mark this as "Fixed" for now.
Automatically closed - issue fixed for 2 weeks with no activity.