- Issue created by @gaurav_manerkar
- Status changed to Needs review
9 months ago 4:05am 14 February 2024 - 🇦🇲Armenia murz Yerevan, Armenia
Looks good, but maybe we need to set the span kind not only for the root and request spans, but for all children spans too? If so, maybe it's good to create a wrapper that creates spans with the required spans.
And maybe it's possible to configure the default span kind via ENV variables or any other way, to not set it explicitly on each new span?
- 🇮🇳India gaurav_manerkar Vasco Da Gama, Goa
Unfortunately SDK doesn't provide any
ENV
variable for SpanKind. By default span usesINTERNAL
spankind.
see https://github.com/opentelemetry-php/sdk/blob/main/Trace/SpanBuilder.php...I have added
KIND_CLIENT
for database span andKIND_SERVER
for span of config form.
For exception span we can use defaultKIND_INTERNAL
Available SpanKinds:
https://opentelemetry.io/docs/specs/otel/trace/api/#spankind - 🇮🇳India gaurav_manerkar Vasco Da Gama, Goa
Replaced deprecated trace attributes
see https://github.com/opentelemetry-php/sem-conv/blob/1.24.0/TraceAttribute... - 🇦🇲Armenia murz Yerevan, Armenia
Regarding the documentation, seems the root span should be with SpanKind=KIND_INTERNAL, cuz it covers the Drupal kernel initialization and finalization, so we need to set SpanKind=KIND_SERVER only for the Request span. @gaurav, what do you think?
- 🇮🇳India gaurav_manerkar Vasco Da Gama, Goa
We can set internal for root span, il update MR
-
Murz →
committed 82a309c7 on 1.0.x authored by
gaurav_manerkar →
Issue #3421123 by gaurav_manerkar, Murz: OpenTelemetry Distributed...
-
Murz →
committed 82a309c7 on 1.0.x authored by
gaurav_manerkar →
- Status changed to Fixed
9 months ago 7:03am 15 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.