- Issue created by @tarikflz
- Merge request !35Issue #3420774: Allow to alter sampler configuration → (Merged) created by tarikflz
- Status changed to Needs review
10 months ago 10:57am 12 February 2024 Hello,
Needs review here. I inject sampler factory while we'r trying to build tracer, which respect env variables maybe we can do this configurable from settings form, waiting for comments..- 🇦🇲Armenia murz Yerevan, Armenia
Good feature, thanks! Left several remarks to the MR.
maybe we can do this configurable from settings form
I think it's okay to make it configurable via ENV variables. OpenTelemetry provides a lot of configurable features, and including all of them will overcomplicate the configuration form.
So I prefer to keep there only main settings, with the ability to configure all other features using environment variables.
-
Murz →
committed 82fc6542 on 1.0.x authored by
tarikflz →
Issue #3420774 by Murz, tarikflz: Allow to alter sampler configuration
-
Murz →
committed 82fc6542 on 1.0.x authored by
tarikflz →
- Status changed to Fixed
10 months ago 1:01pm 12 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.