Remove cruft from NodeRevisions[All]Test::setUp

Created on 9 February 2024, 8 months ago
Updated 3 March 2024, 8 months ago

Problem/Motivation

Both core/modules/node/tests/src/Functional/NodeRevisionsAllTest.php::setUp and \Drupal\Tests\node\Functional\NodeRevisionsTest::setUp code like
$settings = get_object_vars($node); after which nothing at all is done with $settings.

I tried to find out where they came from, but both both seem to come from a conversion of D7 node tests to PSR-0 around 2012/13.
I like some git-archeology, but if that goes further than 10 years without any more recent changes, I'm calling quits...

Steps to reproduce

Proposed resolution

Remove $settings = get_object_vars($node); and friends in both classes

Merge request link

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Fixed

Version

10.2 ✨

Component
Node systemΒ  β†’

Last updated about 17 hours ago

No maintainer
Created by

πŸ‡³πŸ‡±Netherlands spokje

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024