- Issue created by @baldwinlouie
- Merge request !2228Replacing jQuery code in aws_cloud_form.js with native Javascript. β (Merged) created by baldwinlouie
- last update
10 months ago 289 pass, 48 fail - Status changed to Needs review
10 months ago 10:34pm 13 February 2024 - πΊπΈUnited States baldwinlouie
@yas, this patch does the following
1. jQuery from
aws_cloud_form.js
.
2. Change from Select2 library to TomSelect
3. Removes Select2 fromcloud.libraries.yml
4. Renamesaws_cloud_image_import.css
toaws_cloud_tom_select.css
because the CSS can be used in Launch Template and AWS Image import form
5. Fixes a bug inAWSConstraintValidator.php
. The$entity->getName()
throws an exception if this code is called when creating a new AWS Launch Template. This validator gets called when the AJAX on the AWS Launch Template form tries to refresh. - last update
10 months ago 289 pass, 48 fail - last update
10 months ago 289 pass, 48 fail - Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
10 months ago Waiting for branch to pass - Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
10 months ago Waiting for branch to pass - Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
10 months ago Waiting for branch to pass - Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
10 months ago Waiting for branch to pass - Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
10 months ago Waiting for branch to pass - Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
10 months ago Waiting for branch to pass - Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
10 months ago Waiting for branch to pass - Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
10 months ago Waiting for branch to pass - last update
10 months ago 289 pass, 48 fail - last update
10 months ago 289 pass, 48 fail - last update
10 months ago 289 pass, 48 fail - Status changed to RTBC
10 months ago 5:21am 19 February 2024 - πΊπΈUnited States yas California πΊπΈ
@baldwinlouie
Thank you for the fix. I ran the BDD tests and the tests have been passed successfully. So I'll merge the patch to
5.x
and6.x
, and close this issue as Fixed. - Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
10 months ago Waiting for branch to pass -
yas β
committed 4634668c on 6.x authored by
baldwinlouie β
Issue #3420266 by baldwinlouie, yas: Refactor to native JavaScript from...
-
yas β
committed 4634668c on 6.x authored by
baldwinlouie β
- Status changed to Needs work
10 months ago 5:25am 19 February 2024 - πΊπΈUnited States yas California πΊπΈ
@baldwinlouie
We have the error while merging the patch to the 5.x-dev branch:
error: patch failed: modules/cloud_service_providers/aws_cloud/css/aws_cloud_image_import.css:1 error: modules/cloud_service_providers/aws_cloud/css/aws_cloud_image_import.css: patch does not apply
So can you please create the MR for the branch 5,x-dev? Thanks
- Merge request !2230Issue #3386610 by yas, nakamurarts, sekinet: Add a BDD test suite when a user... β (Merged) created by baldwinlouie
- last update
10 months ago Composer require failure - last update
10 months ago 367 pass - Merge request !2231Removed core/jquery and cloud/select2 from aws_cloud.libraries.yml β (Merged) created by baldwinlouie
- last update
10 months ago 289 pass, 48 fail - Status changed to Needs review
10 months ago 4:26am 20 February 2024 - πΊπΈUnited States baldwinlouie
@yas, I created two new MRs.
1. https://git.drupalcode.org/project/cloud/-/merge_requests/2230#note_268665 - This one is the merge into the
5.x</code branch. 2. https://git.drupalcode.org/project/cloud/-/merge_requests/2231 - This one is a hotfix for <code>6.x
branch. I need to clean up
aws_cloud.libraries.yml
and remove thecore/jquery
andcloud/select2
dependency fromaws_cloud_form
- last update
10 months ago 367 pass -
yas β
committed a0a5826a on 5.x authored by
baldwinlouie β
Issue #3420266 by baldwinlouie, yas: Refactor to native JavaScript from...
-
yas β
committed a0a5826a on 5.x authored by
baldwinlouie β
- Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
10 months ago Waiting for branch to pass -
yas β
committed 4efb3399 on 6.x authored by
baldwinlouie β
Issue #3420266 by baldwinlouie, yas: Hotfix - Refactor to native...
-
yas β
committed 4efb3399 on 6.x authored by
baldwinlouie β
- Status changed to Fixed
10 months ago 5:11am 20 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.