Customizations for comment delete form interfere with Core's delete modal in the admin UI

Open on Drupal.org →

Created on 6 February 2024, 12 months ago

Updated 12 August 2024, 6 months ago

Problem/Motivation

In Drupal 10.1 a modal form for delete action in admin UI has been introduced (see 📌 Use a modal for entity delete operation links Fixed ). Basically, now the delete action in admin UI is handled by Ajax request.
The Ajax comments module alters the delete comment form for Ajax requests for handling action links on the Ajax comment form. It relies on attributes added by the JS code of the Ajax comments module but for admin UI it is not the case, and some logic gets broken.

Because of this, the comment delete action is stuck on an unexpected Ajax response and the page is not reloading as it should after a successful action.

Example of log messages:

Deprecated function: substr(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\ajax_comments\TempStore->getSelectorValue() (line 67 of /web/modules/contrib/ajax_comments/src/TempStore.php)

Deprecated function: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in Drupal\ajax_comments\TempStore->getSelectorValue() (line 67 of /web/modules/contrib/ajax_comments/src/TempStore.php)

Steps to reproduce

Drupal 10.2, Ajax comments 8.x-1.x-dev
Go to Manage > Content > Comments
Choose some comment, expand operations link dropdown > Delete > Delete

Expected behaviour
The comment is deleted and has gone from the list.

Actual behavior
Nothing seems changed. However, the comment is actually deleted but the page is not refreshed.

Proposed resolution

Add a few guard clauses to prevent the execution of unintended code parts.

Remaining tasks

No.

User interface changes

No.

API changes

No.

Data model changes

No.

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇬🇪Georgia iamdroid

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!25Customizations for comment delete form interfere with Core's delete modal in the admin UI
Merged
🇳🇱Netherlands idebr
updated 6 months ago

Comments & Activities

Issue created by @iamdroid
Comment 12 months ago →
🇬🇪Georgia iamdroid
Here is the patch.
Status changed to Needs review 7 months ago11:55am 17 June 2024
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update 7 months ago
2 pass
Comment 7 months ago →
🇺🇸United States DamienMcKenna NH, USA
Comment 6 months ago →
🇺🇸United States erutan
After applying this patch if I create a comment from a field in a view it takes me to the admin edit page for that entity. Drupal 10.3.1.
First commit to issue fork.
Merge request !25Issue #3419586: Customizations for comment delete form interfere with Core's... → (Merged) created by idebr
Pipeline finished with Skipped
6 months ago
#237365

Comment 6 months ago →

idebr → committed 2ee51299 on 8.x-1.x

Issue #3419586: Customizations for comment delete form interfere with...

Status changed to Fixed 6 months ago1:04pm 29 July 2024
Comment 6 months ago →
🇳🇱Netherlands idebr
Added \Drupal\Tests\ajax_comments\FunctionalJavascript\AjaxCommentsFunctionalTest::testAdminInterface to confirm the bug.

The patch in #2 fixes the issue. Committed!

Re #4: can you file a new issue for your use case and describe the expected vs. the current behavior? Thanks!
Comment 6 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024