- Issue created by @longwave
- Status changed to Needs review
4 months ago 11:04am 5 February 2024 - 🇬🇧United Kingdom longwave UK
Not massively happy with this solution but it seems the easiest for now. We could switch to Prophecy but that means rewriting far more of the other test methods to also use Prophecy. Or we could use a data provider but then I remembered data providers have to be static in PHPUnit 10 and so we can't use
$this
and then that becomes more complicated too. - Status changed to Needs work
4 months ago 12:11pm 5 February 2024 - Status changed to Needs review
4 months ago 12:35pm 5 February 2024 - Status changed to RTBC
4 months ago 12:51pm 5 February 2024 - 🇳🇱Netherlands Spokje
Code changes make sense, maybe not the most elegant, but we used this method in other issues, and as explained by @longwave, this seems to be the "easiest" (in terms of code changes) way,
- Status changed to Fixed
4 months ago 2:11pm 5 February 2024 - 🇬🇧United Kingdom catch
This also looks OK to me, it's maybe stretching the readability of that pattern compared to the simpler examples elsewhere but it's not bad. Committed/pushed to 11.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.