- Issue created by @longwave
- Status changed to Needs review
7 months ago 7:24pm 31 January 2024 - Status changed to Needs work
7 months ago 8:32pm 31 January 2024 - 🇮🇳India Akhil Babu Chengannur
Akhil Babu → made their first commit to this issue’s fork.
- 🇮🇳India Akhil Babu Chengannur
I have removed the commented code in
core/tests/Drupal/Tests/Core/Menu/LocalTaskManagerTest.php. Also fixed coding standard errors. - Status changed to Needs review
7 months ago 8:22am 1 February 2024 - 🇬🇧United Kingdom longwave UK
Reverted the out of scope changes, fixed the other issues.
- Status changed to RTBC
7 months ago 2:53pm 1 February 2024 - 🇺🇸United States smustgrave
Thanks @longwave, reviewing MR I see green and don't see any coverage is lost.
- Status changed to Fixed
7 months ago 10:41pm 1 February 2024 - 🇬🇧United Kingdom catch
This is nearly as big a diff as all the other MRs combined, who knew menu tests were relying on it so much, but mostly shifting from expects/withConsecutive to ::shouldBeCalled() feels like a small net improvement much like the other issues. Committed/pushed to 11.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.