- Issue created by @chucksimply
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Except I missed some changes, the code is already compatible with Drupal 10. The module just needs to declare itself compatible with Drupal 10.
I do not have a site (even a test site) running on Drupal 10, so I cannot verify if there is anything that needs to be fixed.
- 🇺🇸United States chucksimply
Would it be possible to declare the D10 compatibility in the info file on a new dev release? This way I don't have to do workarounds getting it installed with composer.
- 🇮🇳India dineshkumarbollu
The module is compatible with D10 only below issues are there.Will Provide patch.
FILE: web/modules/contrib/short_scale_formatter/short_scale_formatter.info.yml STATUS LINE MESSAGE -------------------------------------------------------------------------------- Check manually 0 Value of core_version_requirement: ^9.2 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687. -------------------------------------------------------------------------------- FILE: web/modules/contrib/short_scale_formatter/composer.json STATUS LINE MESSAGE -------------------------------------------------------------------------------- Check manually 0 Parse error in composer.json. Having a composer.json is not a requirement in general, but if there is one, it should be valid. See https://drupal.org/node/2514612. --------------------------------------------------------------------------------
- 🇺🇸United States chucksimply
Thanks for the patch! Installed, but when visiting the fields page... received this error.
Fatal error: Could not check compatibility between Drupal\short_scale_formatter\Plugin\Field\FieldFormatter\ShortScaleFormatter::create(Drupal\short_scale_formatter\Plugin\Field\FieldFormatter\ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) and Drupal\Core\Field\FormatterBase::create(Symfony\Component\DependencyInjection\ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition), because class Drupal\short_scale_formatter\Plugin\Field\FieldFormatter\ContainerInterface is not available in /web/modules/contrib/short_scale_formatter/src/Plugin/Field/FieldFormatter/ShortScaleFormatter.php on line 58
- 🇺🇸United States chucksimply
Needed the use statement
use Symfony\Component\DependencyInjection\ContainerInterface;
added to the top of src/Plugin/Field/FieldFormatter/ShortScaleFormatter.php
I'll try uploading a new patch here shortly. Once this statement was added, seems to be working as expected!
- 🇺🇸United States chucksimply
Updated new patch to account for the above.
- Status changed to Needs review
10 months ago 11:05pm 1 February 2024 - Merge request !2Issue #3418156: Make the module compatible with Drupal 10 → (Merged) created by apaderno
-
apaderno →
committed 2ef08ddc on 1.0.x
Issue #3418156: Make the module compatible with Drupal 10
-
apaderno →
committed 2ef08ddc on 1.0.x
- Status changed to Fixed
10 months ago 9:12pm 5 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.