Make the module compatible with Drupal 10

Created on 30 January 2024, 10 months ago
Updated 19 February 2024, 9 months ago

The module is compatible with Drupal 10. Either a new branch should be created for Drupal 10, or the existing branch should define itself as compatible with Drupal 10.

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States chucksimply

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @chucksimply
  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    Except I missed some changes, the code is already compatible with Drupal 10. The module just needs to declare itself compatible with Drupal 10.

    I do not have a site (even a test site) running on Drupal 10, so I cannot verify if there is anything that needs to be fixed.

  • 🇺🇸United States chucksimply

    Would it be possible to declare the D10 compatibility in the info file on a new dev release? This way I don't have to do workarounds getting it installed with composer.

  • 🇮🇳India dineshkumarbollu

    The module is compatible with D10 only below issues are there.Will Provide patch.

    FILE: web/modules/contrib/short_scale_formatter/short_scale_formatter.info.yml
    
    STATUS         LINE                           MESSAGE                           
    --------------------------------------------------------------------------------
    Check manually 0    Value of core_version_requirement: ^9.2 is not compatible   
                        with the next major version of Drupal core. See             
                        https://drupal.org/node/3070687.                            
    --------------------------------------------------------------------------------
    
    FILE: web/modules/contrib/short_scale_formatter/composer.json
    
    STATUS         LINE                           MESSAGE                           
    --------------------------------------------------------------------------------
    Check manually 0    Parse error in composer.json. Having a composer.json is not 
                        a requirement in general, but if there is one, it should be 
                        valid. See https://drupal.org/node/2514612.                 
    --------------------------------------------------------------------------------
    
  • 🇺🇸United States chucksimply

    Thanks for the patch! Installed, but when visiting the fields page... received this error.

    Fatal error: Could not check compatibility between Drupal\short_scale_formatter\Plugin\Field\FieldFormatter\ShortScaleFormatter::create(Drupal\short_scale_formatter\Plugin\Field\FieldFormatter\ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) and Drupal\Core\Field\FormatterBase::create(Symfony\Component\DependencyInjection\ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition), because class Drupal\short_scale_formatter\Plugin\Field\FieldFormatter\ContainerInterface is not available in /web/modules/contrib/short_scale_formatter/src/Plugin/Field/FieldFormatter/ShortScaleFormatter.php on line 58

  • 🇺🇸United States chucksimply

    Needed the use statement

    use Symfony\Component\DependencyInjection\ContainerInterface;

    added to the top of src/Plugin/Field/FieldFormatter/ShortScaleFormatter.php

    I'll try uploading a new patch here shortly. Once this statement was added, seems to be working as expected!

  • 🇺🇸United States chucksimply

    Updated new patch to account for the above.

  • Status changed to Needs review 10 months ago
  • 🇺🇸United States chucksimply

    New patching working flawlessly.

  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • Status changed to Fixed 10 months ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024