- Issue created by @jcontreras
- Assigned to abhishek_virasat
- Issue was unassigned.
- Status changed to Needs review
11 months ago 6:14am 31 January 2024 - 🇮🇳India abhishek_virasat
@jcontreras, fixed the issue and created Patch. please kindly review it.
- 🇵🇹Portugal jrochate
When I added this patch, I got another error and now it's fatal:
TypeError: Drupal\symfony_mailer_log\Plugin\EmailAdjuster\LogMail::Drupal\symfony_mailer_log\Plugin\EmailAdjuster\{closure}(): Argument #1 ($address) must be of type Drupal\symfony_mailer_log\Plugin\EmailAdjuster\AddressInterface, Drupal\symfony_mailer\Address given em Drupal\symfony_mailer_log\Plugin\EmailAdjuster\LogMail->Drupal\symfony_mailer_log\Plugin\EmailAdjuster\{closure}() (linha 124 de /var/www/(...)/web/modules/contrib/symfony_mailer_log/src/Plugin/EmailAdjuster/LogMail.php).
-
svendecabooter →
committed 7dcc6576 on 1.2.x authored by
jrochate →
Issue #3418117 by abhishek_gupta1, jrochate: Wrong call to getLogger()
-
svendecabooter →
committed 7dcc6576 on 1.2.x authored by
jrochate →
- 🇧🇪Belgium svendecabooter Gent
The attached patch fixes an issue with the call to getLogger() - so I have committed it.
However, the original issue reported here is the fact that we set a dynamic property: `$email->_symfony_mailer_log = $log;`
This has not been resolved yet. - Status changed to Needs work
10 months ago 12:30pm 29 February 2024 - First commit to issue fork.
- Merge request !5Issue #3418117: Deprecated function: Creation of dynamic property... → (Merged) created by justafish
- Status changed to Needs review
8 months ago 4:38pm 16 April 2024 - 🇬🇧United Kingdom justafish London, UK
Created an MR to fix the issue with the dynamic property - the LogMail object doesn't seem to get re-used when I stepped through it, so I stored the log object directly there, but maybe someone knows why that might be a bad idea 😅
- 🇳🇱Netherlands Sander Wemagine
I've added a patch that removes the error for us. Hopefully it can help someone else as well (until the repo is updated)
-
svendecabooter →
committed ee2a2e12 on 1.2.x authored by
justafish →
Issue #3418117: Deprecated function: Creation of dynamic property...
-
svendecabooter →
committed ee2a2e12 on 1.2.x authored by
justafish →
- Status changed to Fixed
8 months ago 8:39am 22 April 2024 - 🇧🇪Belgium svendecabooter Gent
Thanks justafish, that seems like the correct approach.
I have merged the MR now. Automatically closed - issue fixed for 2 weeks with no activity.