- Issue created by @Grevil
- Assigned to Grevil
- 🇩🇪Germany Anybody Porta Westfalica
@Grevil I think this should be split into 2 tasks, so the chance to get it fixed is higher. Or will you do both now that you're on it?
- Merge request !9Issue #3417967 by Grevil: Update README and add gitlab-ci.yml → (Merged) created by Grevil
- last update
10 months ago 2 pass - Issue was unassigned.
- Status changed to Needs review
10 months ago 4:08pm 30 January 2024 - last update
10 months ago 2 pass - 🇩🇪Germany Anybody Porta Westfalica
PHPStan is unhappy:
------ ---------------------------------------------------------------------- Line src/FileToMedia.php ------ ---------------------------------------------------------------------- 71 \Drupal calls should be avoided in classes, use dependency injection instead 73 \Drupal calls should be avoided in classes, use dependency injection instead 107 \Drupal calls should be avoided in classes, use dependency injection instead 149 \Drupal calls should be avoided in classes, use dependency injection instead 156 \Drupal calls should be avoided in classes, use dependency injection instead 183 \Drupal calls should be avoided in classes, use dependency injection instead 192 \Drupal calls should be avoided in classes, use dependency injection instead ------ ----------------------------------------------------------------------
You don't have to fix this for me, just FYI.
- Status changed to Needs work
10 months ago 4:46pm 30 January 2024 - 🇩🇪Germany Anybody Porta Westfalica
LGTM & RTBC afterwards. Left just 1 comment. Thank you, wonderful work :)
- Status changed to RTBC
10 months ago 8:09am 31 January 2024 -
Grevil →
committed 84dd66c5 on 1.0.x
Issue #3417967 by Grevil: Update README and add gitlab-ci.yml
-
Grevil →
committed 84dd66c5 on 1.0.x
- Status changed to Fixed
10 months ago 8:10am 31 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.