[1.0.x] Views Reference Field Filter

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

1. FILE: viewsreference_filter.info.yml

core_version_requirement: ^8 || ^9 || ^10

The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement: key.

2. FILE: src/Plugin/ViewsReferenceSetting/ViewsReferenceExposedFilters.php

  /**
   * TaxonomyLookup constructor.
   *
   * @param array $configuration
   *   The configuration.
   * @param string $pluginId
   *   The plugin_id for the plugin instance.
   * @param mixed $pluginDefinition
   *   The plugin implementation definition.
   * @param \Drupal\viewsreference_filter\ViewsRefFilterUtilityInterface $viewsUtility
   *   The views reference filter utility.
   */
  public function __construct(

The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.

3. FILE: src/Plugin/ViewsReferenceSetting/ViewsReferenceExposedFilters.php

  public function __construct(
    array $configuration,
    $pluginId,
    $pluginDefinition,
    ViewsRefFilterUtilityInterface $viewsUtility
  ) {

Function and method declarations are written on a single line.

Hi @vishalkadam,
Sorry if I'm replying on behalf of @roborew as co-maintainer.

Thank you for your review.
The requested changes have already been merged back into the 1.0.x branch, mainly because meanwhile we changed the supported Drupal versions of the module to include support for D11.
We also changed the plugin's constructor declaration to follow the suggested standard.

Best regards

This is the roborew's application, which means that:

• Only roborew can do commits on the project while this application is open
• Only roborew can change status to Needs review

The last seven commits have not been done by roborew. This means this project cannot anymore used by roborew to get the permission to opt projects into security coverage.

The purpose of these applications is reviewing a project to understand what the person who applies understands about writing secure code which follows the Drupal coding standards and correctly uses the Drupal API, not what all the project maintainers collectively understand about those points.

Notice that comment #2 → made clear commits from other maintainers are not accepted while this application is open.

For the time this application is open, only your commits are allowed.

If roborew followed this application and paid attention to the posted comments, he would have told other maintainers they should not do any commit.
Not following the application is, alone, a reason to close an application. The fact that somebody else is following this application (as clear from the last commit, which has not done from the person who created this application, and whose description is Security advisory coverage applications review.) is another reason to close this application.

I am going to close this application as won't fix for the reasons I described here.